Attachment 68260 Details for Bug 55666 – [next] TpConnection: ignore self-handle changes that aren't really changes

[patch] [next] TpConnection: ignore self-handle changes that aren't really changes

0006-TpConnection-ignore-self-handle-changes-that-aren-t-.patch (text/plain), 1020 bytes, created by Simon McVittie on 2012-10-08 13:39:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2012-10-08 13:39:31 UTC

Size: 1020 bytes

patch

obsolete

>From 23d6ac5c8749d622b4fec08ad24960f6c70c48ad Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Mon, 8 Oct 2012 14:31:15 +0100
>Subject: [PATCH 6/7] TpConnection: ignore self-handle changes that aren't
> really changes
>
>---
> telepathy-glib/connection.c |    8 ++++++++
> 1 file changed, 8 insertions(+)
>
>diff --git a/telepathy-glib/connection.c b/telepathy-glib/connection.c
>index 83f04ff..dc70c61 100644
>--- a/telepathy-glib/connection.c
>+++ b/telepathy-glib/connection.c
>@@ -790,6 +790,14 @@ on_self_contact_changed (TpConnection *self,
>       return;
>     }
> 
>+  if (self->priv->last_known_self_handle == self_handle &&
>+      !tp_strdiff (self_id, self->priv->last_known_self_id))
>+    {
>+      DEBUG ("Ignoring no-op self-handle change to %u '%s'",
>+          self_handle, self_id);
>+      return;
>+    }
>+
>   DEBUG ("SelfHandleChanged to %u '%s'", self_handle, self_id);
>   self->priv->last_known_self_handle = self_handle;
>   g_free (self->priv->last_known_self_id);
>-- 
>1.7.10.4
>

Actions: View | Splinter Review

Attachments on bug 55666: 68122 | 68123 | 68124 | 68125 | 68250 | 68255 | 68256 | 68257 | 68258 | 68259 | 68260 | 68261

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.