Attachment 68678 Details for Bug 56044 – base-call-channel: Ignore spurious transitions

[patch] base-call-channel: Ignore spurious transitions

0001-base-call-channel-Ignore-spurious-transitions.patch (text/plain), 972 bytes, created by Debarshi Ray on 2012-10-17 09:28:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Debarshi Ray

Created: 2012-10-17 09:28:36 UTC

Size: 972 bytes

patch

obsolete

>From 14a8069f32af3e582b4c77d8160be75e406a8d91 Mon Sep 17 00:00:00 2001
>From: Debarshi Ray <rishi@gnu.org>
>Date: Wed, 17 Oct 2012 10:50:24 +0200
>Subject: [PATCH] base-call-channel: Ignore spurious transitions
>
>... in tp_base_call_channel_set_state where the current and new state
>are the same.
>
>Fixes: https://bugs.freedesktop.org/56044
>---
> telepathy-glib/base-call-channel.c | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/telepathy-glib/base-call-channel.c b/telepathy-glib/base-call-channel.c
>index af82ba1..825c42f 100644
>--- a/telepathy-glib/base-call-channel.c
>+++ b/telepathy-glib/base-call-channel.c
>@@ -791,6 +791,9 @@ tp_base_call_channel_set_state (TpBaseCallChannel *self,
>   self->priv->reason = _tp_base_call_state_reason_new (actor_handle, reason,
>       dbus_reason, message);
> 
>+  if (old_state == state)
>+    return;
>+
>   if (self->priv->state != TP_CALL_STATE_INITIALISED)
>     self->priv->flags &= ~TP_CALL_FLAG_LOCALLY_RINGING;
> 
>-- 
>1.7.12.1
>

Actions: View | Splinter Review

Attachments on bug 56044: 68639 | 68640 | 68678 | 68689 | 68700 | 68701 | 68707

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.