Attachment 70702 Details for Bug 57632 – 0004-Do-not-use-size-uninitialized.patch

[patch] 0004-Do-not-use-size-uninitialized.patch

0004-Do-not-use-size-uninitialized.patch (text/plain), 1.05 KB, created by Hib Eris on 2012-11-27 22:21:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Hib Eris

Created: 2012-11-27 22:21:49 UTC

Size: 1.05 KB

patch

obsolete

>From 2c3ba0b5d37d88edb305609f5bce850ede1affd3 Mon Sep 17 00:00:00 2001
>From: Hib Eris <hib@hiberis.nl>
>Date: Sat, 23 Jun 2012 18:23:59 +0200
>Subject: [PATCH 4/5] Do not use 'size' uninitialized
>
>---
> poppler/PDFDoc.cc |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/poppler/PDFDoc.cc b/poppler/PDFDoc.cc
>index f52d498..989086b 100644
>--- a/poppler/PDFDoc.cc
>+++ b/poppler/PDFDoc.cc
>@@ -189,7 +189,7 @@ PDFDoc::PDFDoc(wchar_t *fileNameA, int fileNameLen, GooString *ownerPassword,
>   // try to open file
>   // NB: _wfopen is only available in NT
>   struct _stat buf;
>-  int size;
>+  int size = 0;
>   version.dwOSVersionInfoSize = sizeof(version);
>   GetVersionEx(&version);
>   if (version.dwPlatformId == VER_PLATFORM_WIN32_NT) {
>@@ -203,7 +203,7 @@ PDFDoc::PDFDoc(wchar_t *fileNameA, int fileNameLen, GooString *ownerPassword,
>     }
>     file = fopen(fileName->getCString(), "rb");
>   }
>-  if (!file) {
>+  if (!size || !file) {
>     error(errIO, -1, "Couldn't open file '{0:t}'", fileName);
>     errCode = errOpenFile;
>     return;
>-- 
>1.7.5.4
>

Actions: View | Splinter Review

Attachments on bug 57632: 70699 | 70700 | 70701 | 70702 | 70703

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.