Attachment 71118 Details for Bug 57963 – Customize i915_gpu_idle() for seqno wrapping

[patch] Customize i915_gpu_idle() for seqno wrapping

0001-drm-i915-Open-code-i915_gpu_idle-for-handling-seqno-.patch (text/plain), 1.43 KB, created by Chris Wilson on 2012-12-07 08:49:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Wilson

Created: 2012-12-07 08:49:22 UTC

Size: 1.43 KB

patch

obsolete

>From 8717daca7c3ed07493b0796b2f8052e816f465f2 Mon Sep 17 00:00:00 2001
>From: Chris Wilson <chris@chris-wilson.co.uk>
>Date: Fri, 7 Dec 2012 08:46:15 +0000
>Subject: [PATCH] drm/i915: Open-code i915_gpu_idle() for handling seqno
> wrapping
>
>The complication is that during seqno wrapping we must be extremely
>careful not to write to any ring as that will require a new seqno, and
>so would recurse back into the seqno wrap handler. So we cannot call
>i915_gpu_idle() as that does additional work beyond simply retiring the
>current set of requests, and instead must do the minimal work ourselves
>during seqno wrapping.
>
>Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>---
> drivers/gpu/drm/i915/i915_gem.c |   12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
>index 2f65230..aa8b567 100644
>--- a/drivers/gpu/drm/i915/i915_gem.c
>+++ b/drivers/gpu/drm/i915/i915_gem.c
>@@ -2030,11 +2030,15 @@ i915_gem_handle_seqno_wrap(struct drm_device *dev)
> 	if (ret == 0)
> 		return ret;
> 
>-	ret = i915_gpu_idle(dev);
>-	if (ret)
>-		return ret;
>-
>+	/* Carefully retire all requests without writing to the rings */
>+	for_each_ring(ring, dev_priv, i) {
>+		ret = intel_ring_idle(ring);
>+		if (ret)
>+			return ret;
>+	}
> 	i915_gem_retire_requests(dev);
>+
>+	/* Finally reset hw state */
> 	for_each_ring(ring, dev_priv, i) {
> 		ret = intel_ring_handle_seqno_wrap(ring);
> 		if (ret)
>-- 
>1.7.10.4
>

Actions: View | Splinter Review

Attachments on bug 57963: 71108 | 71118

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.