Attachment 71247 Details for Bug 58010 – set fdi TX enhanced framing before enabling port

[patch] set fdi TX enhanced framing before enabling port

0001-drm-i915-set-fdi-TX-enhanced-framing-before-enabling.patch (text/plain), 1.55 KB, created by Daniel Vetter on 2012-12-09 22:54:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Vetter

Created: 2012-12-09 22:54:30 UTC

Size: 1.55 KB

patch

obsolete

>From 138a9d05b1867bb06372b52fd79f1d1d2eafb05c Mon Sep 17 00:00:00 2001
>From: Daniel Vetter <daniel.vetter@ffwll.ch>
>Date: Mon, 10 Dec 2012 00:10:30 +0100
>Subject: [PATCH] drm/i915: set fdi TX enhanced framing before enabling port
>
>Bspec says that this bit is locked once the port is enabled. Frobbing
>the register directly it still seems to update, but I guess they mean
>the hw state ...
>
>Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>---
> drivers/gpu/drm/i915/intel_display.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
>index 3256a34..b59739a 100644
>--- a/drivers/gpu/drm/i915/intel_display.c
>+++ b/drivers/gpu/drm/i915/intel_display.c
>@@ -2307,10 +2307,10 @@ static void intel_fdi_normal_train(struct drm_crtc *crtc)
> 	temp = I915_READ(reg);
> 	if (IS_IVYBRIDGE(dev)) {
> 		temp &= ~FDI_LINK_TRAIN_NONE_IVB;
>-		temp |= FDI_LINK_TRAIN_NONE_IVB | FDI_TX_ENHANCE_FRAME_ENABLE;
>+		temp |= FDI_LINK_TRAIN_NONE_IVB;
> 	} else {
> 		temp &= ~FDI_LINK_TRAIN_NONE;
>-		temp |= FDI_LINK_TRAIN_NONE | FDI_TX_ENHANCE_FRAME_ENABLE;
>+		temp |= FDI_LINK_TRAIN_NONE;
> 	}
> 	I915_WRITE(reg, temp);
> 
>@@ -2756,6 +2756,8 @@ static void ironlake_fdi_pll_enable(struct intel_crtc *intel_crtc)
> 	/* Enable CPU FDI TX PLL, always on for Ironlake */
> 	reg = FDI_TX_CTL(pipe);
> 	temp = I915_READ(reg);
>+	/* TX enhanced framing is locked once port is enabled. */
>+	temp |= FDI_TX_ENHANCE_FRAME_ENABLE;
> 	if ((temp & FDI_TX_PLL_ENABLE) == 0) {
> 		I915_WRITE(reg, temp | FDI_TX_PLL_ENABLE);
> 
>-- 
>1.7.11.7
>

Actions: View | Splinter Review

Attachments on bug 58010: 71187 | 71234 | 71247

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.