Attachment 72248 Details for Bug 58851 – Add some missing introspection annotations

[patch] Add some missing introspection annotations

0001-Add-some-missing-element-type-introspection-annotati.patch (text/plain), 2.18 KB, created by Philip Withnall on 2012-12-29 12:06:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Philip Withnall

Created: 2012-12-29 12:06:19 UTC

Size: 2.18 KB

patch

obsolete

>From ed45b47aff81037102be9874b33ada76c6cd45e9 Mon Sep 17 00:00:00 2001
>From: Philip Withnall <philip@tecnocode.co.uk>
>Date: Sat, 29 Dec 2012 11:41:50 +0000
>Subject: [PATCH] Add some missing (element-type) introspection annotations
>
>This fixes compilation with --enable-introspection when introspection
>warnings are treated as errors.
>
>Signed-off-by: Robert McQueen <robert.mcqueen@collabora.co.uk>
>---
> telepathy-glib/capabilities.c           | 4 ++--
> telepathy-glib/client-channel-factory.c | 2 +-
> telepathy-glib/dbus.c                   | 3 ++-
> 3 files changed, 5 insertions(+), 4 deletions(-)
>
>diff --git a/telepathy-glib/capabilities.c b/telepathy-glib/capabilities.c
>index ae1d34f..4ddf368 100644
>--- a/telepathy-glib/capabilities.c
>+++ b/telepathy-glib/capabilities.c
>@@ -84,8 +84,8 @@ struct _TpCapabilitiesPrivate {
>  *
>  * 
>  *
>- * Returns: (transfer none): the same #GPtrArray as the
>- * #TpCapabilities:channel-classes property
>+ * Returns: (transfer none) (element-type GHashTable): the same #GPtrArray as
>+ * the #TpCapabilities:channel-classes property
>  *
>  * Since: 0.11.3
>  */
>diff --git a/telepathy-glib/client-channel-factory.c b/telepathy-glib/client-channel-factory.c
>index c5d3cf4..3dbf7af 100644
>--- a/telepathy-glib/client-channel-factory.c
>+++ b/telepathy-glib/client-channel-factory.c
>@@ -139,7 +139,7 @@ tp_client_channel_factory_create_channel (TpClientChannelFactory *self,
>  * it expected an object instance as its first parameter, but the type of the
>  * parameter was the type of the interface vtable.
>  *
>- * Returns: (transfer full): a newly allocated #GArray
>+ * Returns: (transfer full) (element-type GQuark): a newly allocated #GArray
>  *
>  * Since: 0.13.3
>  */
>diff --git a/telepathy-glib/dbus.c b/telepathy-glib/dbus.c
>index 04ba84b..ba28e29 100644
>--- a/telepathy-glib/dbus.c
>+++ b/telepathy-glib/dbus.c
>@@ -881,7 +881,8 @@ tp_asv_set_boolean (GHashTable *asv,
>  * g_boxed_copy (DBUS_TYPE_G_UCHAR_ARRAY, ...) if you need to keep
>  * it for longer.
>  *
>- * Returns: (transfer none) (allow-none): the string value of @key, or %NULL
>+ * Returns: (transfer none) (allow-none) (element-type guint8): the string value
>+ * of @key, or %NULL
>  * Since: 0.7.9
>  */
> const GArray *
>-- 
>1.7.11.7
>

Actions: View | Splinter Review

Attachments on bug 58851: 72238 | 72248

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.