Attachment 72438 Details for Bug 52011 – tp_base_contact_list_set_list_received: don't re-announce groups

[patch] tp_base_contact_list_set_list_received: don't re-announce groups

0001-tp_base_contact_list_set_list_received-don-t-re-anno.patch (text/plain), 1.84 KB, created by Simon McVittie on 2013-01-03 11:15:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2013-01-03 11:15:55 UTC

Size: 1.84 KB

patch

obsolete

>From d79973ce4a3c368ae50fd32d55a62af7342a8f0c Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Thu, 3 Jan 2013 11:02:52 +0000
>Subject: [PATCH] tp_base_contact_list_set_list_received: don't re-announce
> groups
>
>We already announced each group from tp_base_contact_list_groups_created
>a few lines ago; we don't need to do it again.
>
>Ideally we'd add each channel's members before announcing the
>channel itself, so that the channel is created "fully-formed"; but
>we've never actually done that, and keeping the first NewChannels
>instead of the second seems less likely to break applications.
>These channels are only for legacy code anyway: any modern client
>should be using the ContactGroups interface.
>
>Bug: https://bugs.freedesktop.org/show_bug.cgi?id=52011
>Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
>---
> telepathy-glib/base-contact-list.c |    7 -------
> 1 file changed, 7 deletions(-)
>
>diff --git a/telepathy-glib/base-contact-list.c b/telepathy-glib/base-contact-list.c
>index 7e62753..d24e5ce 100644
>--- a/telepathy-glib/base-contact-list.c
>+++ b/telepathy-glib/base-contact-list.c
>@@ -2008,8 +2008,6 @@ tp_base_contact_list_set_list_received (TpBaseContactList *self)
>   if (TP_IS_CONTACT_GROUP_LIST (self))
>     {
>       GStrv groups = tp_base_contact_list_dup_groups (self);
>-      GHashTableIter h_iter;
>-      gpointer channel;
> 
>       tp_base_contact_list_groups_created (self,
>           (const gchar * const *) groups, -1);
>@@ -2024,11 +2022,6 @@ tp_base_contact_list_set_list_received (TpBaseContactList *self)
>           tp_handle_set_destroy (members);
>         }
> 
>-      g_hash_table_iter_init (&h_iter, self->priv->groups);
>-
>-      while (g_hash_table_iter_next (&h_iter, NULL, &channel))
>-        tp_base_contact_list_announce_channel (self, channel, NULL);
>-
>       g_strfreev (groups);
>     }
> 
>-- 
>1.7.10.4
>

Actions: View | Splinter Review

Attachments on bug 52011: 64139 | 72438 | 72442

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.