Attachment 76592 Details for Bug 60802 – take 5

[patch] take 5

0001-r600g-fall-back-to-blitter-for-compressed-textures-o.patch (text/plain), 1.35 KB, created by Alex Deucher on 2013-03-15 22:17:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Deucher

Created: 2013-03-15 22:17:07 UTC

Size: 1.35 KB

patch

obsolete

>From ffbadf5ea99e73b2d02ec25a1663670a09046470 Mon Sep 17 00:00:00 2001
>From: Alex Deucher <alexander.deucher@amd.com>
>Date: Fri, 15 Mar 2013 14:29:24 -0400
>Subject: [PATCH 1/2] r600g: fall back to blitter for compressed textures on
> cayman (v2)
>
>The DMA block seems to have alignment issues with large
>block sizes.  Use the blitter for these surfaces.
>
>v2: cayman/TN only
>
>Fixes:
>https://bugs.freedesktop.org/show_bug.cgi?id=60802
>
>Note: this is a candidate for the 9.1 branch.
>
>Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
>---
> src/gallium/drivers/r600/evergreen_state.c |    9 +++++++++
> 1 files changed, 9 insertions(+), 0 deletions(-)
>
>diff --git a/src/gallium/drivers/r600/evergreen_state.c b/src/gallium/drivers/r600/evergreen_state.c
>index 2bdefb0..b40ed01 100644
>--- a/src/gallium/drivers/r600/evergreen_state.c
>+++ b/src/gallium/drivers/r600/evergreen_state.c
>@@ -3674,6 +3674,15 @@ boolean evergreen_dma_blit(struct pipe_context *ctx,
> 		return FALSE;
> 	}
> 
>+	/* The DMA block on cayman seems to have alignment issues
>+	 * with large block sizes.  Needs more investigation.
>+	 */
>+	if ((rctx->chip_class == CAYMAN) &&
>+	    (src_mode != dst_mode) &&
>+	    (util_format_get_blocksize(src->format) >= 16)) {
>+		return FALSE;
>+	}
>+
> 	if (src_mode == dst_mode) {
> 		uint64_t dst_offset, src_offset;
> 		/* simple dma blit would do NOTE code here assume :
>-- 
>1.7.7.5
>

Actions: View | Splinter Review

Attachments on bug 60802: 74793 | 75658 | 75725 | 76544 | 76557 | 76563 | 76590 | 76592

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.