Attachment 80065 Details for Bug 65131 – hack: don't send telephone-event PTs to Google webmail

[patch] hack: don't send telephone-event PTs to Google webmail

0001-hack-don-t-send-telephone-event-PTs-to-Google-webmai.patch (text/plain), 1.35 KB, created by Simon McVittie on 2013-05-30 19:32:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2013-05-30 19:32:39 UTC

Size: 1.35 KB

patch

obsolete

>From c971f0982d199a7ce0bc501a6b9fcfffbf105589 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Thu, 30 May 2013 20:30:56 +0100
>Subject: [PATCH] hack: don't send telephone-event PTs to Google webmail
>
>On one OS I've tried (but not on Debian for some reason...),
>we get 'incompatible-parameters' from the Google web UI if
>we tell them we support telephone events. Your guess is
>as good as mine...
>
>I doubt this should actually be merged, but it's a start.
>---
> wocky/wocky-jingle-media-rtp.c |    9 +++++++++
> 1 file changed, 9 insertions(+)
>
>diff --git a/wocky/wocky-jingle-media-rtp.c b/wocky/wocky-jingle-media-rtp.c
>index 24b0a10..9d3c7b8 100644
>--- a/wocky/wocky-jingle-media-rtp.c
>+++ b/wocky/wocky-jingle-media-rtp.c
>@@ -963,6 +963,15 @@ produce_payload_type (WockyJingleContent *content,
> 
>   pt_node = wocky_node_add_child (desc_node, "payload-type");
> 
>+  /* I don't know why this fixes interop with the Google web UI, but it does.
>+   *
>+   * FIXME: this relies on us speaking GTalk dialect to the Google web UI.
>+   * It can in fact understand normal RTP, so we should have a better
>+   * condition. */
>+  if (WOCKY_JINGLE_DIALECT_IS_GOOGLE (dialect) &&
>+      !wocky_strdiff (p->name, "telephone-event"))
>+    return;
>+
>   /* id: required */
>   sprintf (buf, "%d", p->id);
>   wocky_node_set_attribute (pt_node, "id", buf);
>-- 
>1.7.10.4
>

Actions: View | Splinter Review

Attachments on bug 65131: 79970 | 79971 | 80051 | 80052 | 80062 | 80065 | 80196 | 80197

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.