Attachment 80562 Details for Bug 58405 – fix sdvo hotplug init sequence

[patch] fix sdvo hotplug init sequence

fix-sdvo-hotplug-init-sequence.patch (text/plain), 1.17 KB, created by Daniel Vetter on 2013-06-09 11:54:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Vetter

Created: 2013-06-09 11:54:04 UTC

Size: 1.17 KB

patch

obsolete

>diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c
>index 960358d..2853a74 100644
>--- a/drivers/gpu/drm/i915/intel_sdvo.c
>+++ b/drivers/gpu/drm/i915/intel_sdvo.c
>@@ -2891,12 +2891,6 @@ bool intel_sdvo_init(struct drm_device *dev, uint32_t sdvo_reg, bool is_sdvob)
> 			SDVOB_HOTPLUG_INT_STATUS_I915 : SDVOC_HOTPLUG_INT_STATUS_I915;
> 	}
> 
>-	/* Only enable the hotplug irq if we need it, to work around noisy
>-	 * hotplug lines.
>-	 */
>-	if (intel_sdvo->hotplug_active)
>-		intel_encoder->hpd_pin = HPD_SDVO_B ? HPD_SDVO_B : HPD_SDVO_C;
>-
> 	intel_encoder->compute_config = intel_sdvo_compute_config;
> 	intel_encoder->disable = intel_disable_sdvo;
> 	intel_encoder->mode_set = intel_sdvo_mode_set;
>@@ -2916,6 +2910,12 @@ bool intel_sdvo_init(struct drm_device *dev, uint32_t sdvo_reg, bool is_sdvob)
> 		goto err_output;
> 	}
> 
>+	/* Only enable the hotplug irq if we need it, to work around noisy
>+	 * hotplug lines.
>+	 */
>+	if (intel_sdvo->hotplug_active)
>+		intel_encoder->hpd_pin = HPD_SDVO_B ? HPD_SDVO_B : HPD_SDVO_C;
>+
> 	/*
> 	 * Cloning SDVO with anything is often impossible, since the SDVO
> 	 * encoder can request a special input timing mode. And even if that's

Actions: View | Splinter Review

Attachments on bug 58405: 71661 | 71664 | 73299 | 73300 | 73301 | 73302 | 80528 | 80562 | 80572 | 80578 | 80579 | 80586 | 81358

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.