Attachment 82366 Details for Bug 66837 – possible fix

[patch] possible fix

0001-r600g-don-t-use-the-CB-DB-CP-COHER-logic-on-r6xx.patch (text/plain), 1.53 KB, created by Alex Deucher on 2013-07-12 13:33:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Deucher

Created: 2013-07-12 13:33:51 UTC

Size: 1.53 KB

patch

obsolete

>From 8262c1ff150d23f588aa6624e7bdf3ea4eb05284 Mon Sep 17 00:00:00 2001
>From: Alex Deucher <alexander.deucher@amd.com>
>Date: Fri, 12 Jul 2013 09:31:28 -0400
>Subject: [PATCH] r600g: don't use the CB/DB CP COHER logic on r6xx
>
>There are hw bugs.  Flush and inv event is sufficient.
>
>May fix:
>https://bugs.freedesktop.org/show_bug.cgi?id=66837
>
>Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
>---
> src/gallium/drivers/r600/r600_hw_context.c |   12 ++++++++++--
> 1 files changed, 10 insertions(+), 2 deletions(-)
>
>diff --git a/src/gallium/drivers/r600/r600_hw_context.c b/src/gallium/drivers/r600/r600_hw_context.c
>index 652329b..7bb4825 100644
>--- a/src/gallium/drivers/r600/r600_hw_context.c
>+++ b/src/gallium/drivers/r600/r600_hw_context.c
>@@ -246,13 +246,21 @@ void r600_flush_emit(struct r600_context *rctx)
> 		cp_coher_cntl |= S_0085F0_TC_ACTION_ENA(1);
> 	}
> 
>-	if (rctx->flags & R600_CONTEXT_FLUSH_AND_INV_DB) {
>+	/* Don't use the DB CP COHER logic on r6xx.
>+	 * There are hw bugs.
>+	 */
>+	if (rctx->chip_class >= R700 &&
>+	    (rctx->flags & R600_CONTEXT_FLUSH_AND_INV_DB)) {
> 		cp_coher_cntl |= S_0085F0_DB_ACTION_ENA(1) |
> 				S_0085F0_DB_DEST_BASE_ENA(1) |
> 				S_0085F0_SMX_ACTION_ENA(1);
> 	}
> 
>-	if (rctx->flags & R600_CONTEXT_FLUSH_AND_INV_CB) {
>+	/* Don't use the CB CP COHER logic on r6xx.
>+	 * There are hw bugs.
>+	 */
>+	if (rctx->chip_class >= R700 &&
>+	    (rctx->flags & R600_CONTEXT_FLUSH_AND_INV_CB)) {
> 		cp_coher_cntl |= S_0085F0_CB_ACTION_ENA(1) |
> 				S_0085F0_CB0_DEST_BASE_ENA(1) |
> 				S_0085F0_CB1_DEST_BASE_ENA(1) |
>-- 
>1.7.7.5
>

Actions: View | Splinter Review

Attachments on bug 66837: 82366

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.