Attachment 82560 Details for Bug 66932 – fix

[patch] fix

0001-drm-radeon-dpm-atom-restructure-logic-to-work-around.patch (text/plain), 1.49 KB, created by Alex Deucher on 2013-07-17 18:16:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Deucher

Created: 2013-07-17 18:16:10 UTC

Size: 1.49 KB

patch

obsolete

>From f1dde1156ab79ac604dbe8072f165bac7124cd63 Mon Sep 17 00:00:00 2001
>From: Andre Heider <a.heider@gmail.com>
>Date: Wed, 17 Jul 2013 14:02:23 -0400
>Subject: [PATCH] drm/radeon/dpm/atom: restructure logic to work around a
> compiler bug
>
>It seems some compilers generate bogus code for the old logic causing
>part of the function to get skipped.
>
>Fixes:
>https://bugs.freedesktop.org/show_bug.cgi?id=66932
>https://bugs.freedesktop.org/show_bug.cgi?id=66972
>https://bugs.freedesktop.org/show_bug.cgi?id=66945
>
>Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
>---
> drivers/gpu/drm/radeon/radeon_atombios.c |    5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/radeon/radeon_atombios.c b/drivers/gpu/drm/radeon/radeon_atombios.c
>index 9890b45..878b814 100644
>--- a/drivers/gpu/drm/radeon/radeon_atombios.c
>+++ b/drivers/gpu/drm/radeon/radeon_atombios.c
>@@ -3719,8 +3719,9 @@ int radeon_atom_init_mc_reg_table(struct radeon_device *rdev,
> 							   sizeof(ATOM_INIT_REG_INDEX_FORMAT)) - 1;
> 					if (num_entries > VBIOS_MC_REGISTER_ARRAY_SIZE)
> 						return -EINVAL;
>-					while (!(reg_block->asRegIndexBuf[i].ucPreRegDataLength & ACCESS_PLACEHOLDER) &&
>-					      (i < num_entries)) {
>+					while (i < num_entries) {
>+						if (reg_block->asRegIndexBuf[i].ucPreRegDataLength & ACCESS_PLACEHOLDER)
>+							break;
> 						reg_table->mc_reg_address[i].s1 =
> 							(u16)(le16_to_cpu(reg_block->asRegIndexBuf[i].usRegIndex));
> 						reg_table->mc_reg_address[i].pre_reg_data =
>-- 
>1.7.7.5
>

Actions: View | Splinter Review

Attachments on bug 66932: 82448 | 82449 | 82501 | 82519 | 82534 | 82551 | 82552 | 82559 | 82560 | 82563

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.