Attachment 83776 Details for Bug 45163 – Proposed patch

[patch] Proposed patch

0001-Fix-pdftotext-bbox-in.pdf.patch (text/plain), 1.23 KB, created by Yury G. Kudryashov on 2013-08-07 09:41:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Yury G. Kudryashov

Created: 2013-08-07 09:41:39 UTC

Size: 1.23 KB

patch

obsolete

>From 5118029d4d0ba5bcb27cbef2b3245c9fb654f72c Mon Sep 17 00:00:00 2001
>From: "Yury G. Kudryashov" <urkud.urkud@gmail.com>
>Date: Wed, 7 Aug 2013 13:09:17 +0400
>Subject: [PATCH] Fix `pdftotext -bbox in.pdf -`
>
>Print body text to stdout if invoked as above.
>
>https://bugs.freedesktop.org/show_bug.cgi?id=45163
>---
> utils/pdftotext.cc | 14 +++++---------
> 1 file changed, 5 insertions(+), 9 deletions(-)
>
>diff --git a/utils/pdftotext.cc b/utils/pdftotext.cc
>index a170f1b..b83eb4a 100644
>--- a/utils/pdftotext.cc
>+++ b/utils/pdftotext.cc
>@@ -331,21 +331,17 @@ int main(int argc, char *argv[]) {
>     info.free();
>     fputs("</head>\n", f);
>     fputs("<body>\n", f);
>-    if (!bbox) fputs("<pre>\n", f);
>-    if (f != stdout) {
>-      fclose(f);
>+    if (!bbox) {
>+      fputs("<pre>\n", f);
>+      if (f != stdout) {
>+	fclose(f);
>+      }
>     }
>   }
> 
>   // write text file
>   if (bbox) {
>     textOut = new TextOutputDev(NULL, physLayout, fixedPitch, rawOrder, htmlMeta);
>-    if (!(f = fopen(textFileName->getCString(), "ab"))) {
>-      error(errIO, -1, "Couldn't open text file '{0:t}' for append", textFileName);
>-      exitCode = 2;
>-      delete textOut;
>-      goto err3;
>-    }
> 
>     if (textOut->isOk()) {
>       fprintf(f, "<doc>\n");
>-- 
>1.8.1.2
>

Actions: View | Splinter Review

Attachments on bug 45163: 83776

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.