Attachment 85357 Details for Bug 69038 – Pass correct pointer type to ldap_set_option when setting SSF_MIN

[patch] Pass correct pointer type to ldap_set_option when setting SSF_MIN

Pass-correct-pointer-type-to-ldapsetoption-when-se.patch (text/plain), 1.17 KB, created by Stef Walter on 2013-09-06 14:35:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Stef Walter

Created: 2013-09-06 14:35:08 UTC

Size: 1.17 KB

patch

obsolete

>From 167b4e9fefa3a1f535548e756c7cba21c7678eae Mon Sep 17 00:00:00 2001
>From: Stef Walter <stefw@redhat.com>
>Date: Fri, 6 Sep 2013 16:34:23 +0200
>Subject: [PATCH] Pass correct pointer type to ldap_set_option when setting
> SSF_MIN
>
>Failure on some archs where sizeof(int) != sizeof(ber_len_t)
>
>https://bugs.freedesktop.org/show_bug.cgi?id=69038
>---
> library/adconn.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/library/adconn.c b/library/adconn.c
>index 6efda0f..0881602 100644
>--- a/library/adconn.c
>+++ b/library/adconn.c
>@@ -968,7 +968,7 @@ authenticate_to_directory (adcli_conn *conn)
> {
> 	OM_uint32 status;
> 	OM_uint32 minor;
>-	int opt;
>+	ber_len_t ssf;
> 	int ret;
> 
> 	if (conn->ldap_authenticated)
>@@ -982,8 +982,8 @@ authenticate_to_directory (adcli_conn *conn)
> 	return_unexpected_if_fail (status == 0);
> 
> 	/* Clumsily tell ldap + cyrus-sasl that we want encryption */
>-	opt = 1;
>-	ret = ldap_set_option (conn->ldap, LDAP_OPT_X_SASL_SSF_MIN, &opt);
>+	ssf = 1;
>+	ret = ldap_set_option (conn->ldap, LDAP_OPT_X_SASL_SSF_MIN, &ssf);
> 	return_unexpected_if_fail (ret == 0);
> 
> 	ret = ldap_sasl_interactive_bind_s (conn->ldap, NULL, "GSSAPI", NULL, NULL,
>-- 
>1.8.3.1

Actions: View | Splinter Review

Attachments on bug 69038: 85357

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.