Attachment 85934 Details for Bug 69272 – 4/4] All .c files: include corresponding header first, after config.h

[patch] 4/4] All .c files: include corresponding header first, after config.h

0004-All-.c-files-include-corresponding-header-first-afte.patch (text/plain), 1.68 KB, created by Simon McVittie on 2013-09-16 18:40:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2013-09-16 18:40:01 UTC

Size: 1.68 KB

patch

obsolete

>From c5bb806751ca5dc9fb96cc7750c3487963fae20f Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Mon, 16 Sep 2013 19:38:35 +0100
>Subject: [PATCH 4/4] All .c files: include corresponding header first, after
> config.h
>
>This verifies self-containedness. It turns out contact-list was not
>actually self-contained: include <libpurple/account.h> to fix that.
>
>Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69272
>---
> src/connection-manager.c | 2 +-
> src/contact-list.c       | 2 +-
> src/contact-list.h       | 2 ++
> 3 files changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/src/connection-manager.c b/src/connection-manager.c
>index 9bf3f2a..58c802d 100644
>--- a/src/connection-manager.c
>+++ b/src/connection-manager.c
>@@ -20,6 +20,7 @@
>  */
> 
> #include <config.h>
>+#include "connection-manager.h"
> 
> #include <string.h>
> 
>@@ -31,7 +32,6 @@
> 
> #include <telepathy-glib/telepathy-glib.h>
> 
>-#include "connection-manager.h"
> #include "debug.h"
> 
> G_DEFINE_TYPE(HazeConnectionManager,
>diff --git a/src/contact-list.c b/src/contact-list.c
>index f9d6cc2..107f9e9 100644
>--- a/src/contact-list.c
>+++ b/src/contact-list.c
>@@ -20,13 +20,13 @@
>  */
> 
> #include <config.h>
>+#include "contact-list.h"
> 
> #include <string.h>
> 
> #include <telepathy-glib/telepathy-glib.h>
> 
> #include "connection.h"
>-#include "contact-list.h"
> #include "debug.h"
> 
> typedef struct _PublishRequestData PublishRequestData;
>diff --git a/src/contact-list.h b/src/contact-list.h
>index e8bcb77..647a40d 100644
>--- a/src/contact-list.h
>+++ b/src/contact-list.h
>@@ -22,6 +22,8 @@
> 
> #include <glib-object.h>
> 
>+#include <libpurple/account.h>
>+
> #include <telepathy-glib/telepathy-glib.h>
> 
> G_BEGIN_DECLS
>-- 
>1.8.4.rc3
>

Actions: View | Splinter Review

Attachments on bug 69272: 85720 | 85721 | 85722 | 85726 | 85931 | 85932 | 85933 | 85934

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.