Attachment 85980 Details for Bug 69466 – factor out add_always_present_connection_interfaces()

[patch] factor out add_always_present_connection_interfaces()

0004-factor-out-add_always_present_connection_interfaces.patch (text/plain), 1.38 KB, created by Guillaume Desmottes on 2013-09-17 13:30:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Guillaume Desmottes

Created: 2013-09-17 13:30:59 UTC

Size: 1.38 KB

patch

obsolete

>From 3b33ffa0a250a645189f65271d7407bb6a87bd9e Mon Sep 17 00:00:00 2001
>From: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
>Date: Tue, 17 Sep 2013 15:09:43 +0200
>Subject: [PATCH 4/5] factor out add_always_present_connection_interfaces()
>
>https://bugs.freedesktop.org/show_bug.cgi?id=69466
>---
> src/connection.c | 15 +++++++++++----
> 1 file changed, 11 insertions(+), 4 deletions(-)
>
>diff --git a/src/connection.c b/src/connection.c
>index 1b4a729..9413519 100644
>--- a/src/connection.c
>+++ b/src/connection.c
>@@ -113,18 +113,25 @@ haze_connection_get_implemented_interfaces (void)
>   return implemented_interfaces;
> }
> 
>+static void
>+add_always_present_connection_interfaces (GPtrArray *interfaces)
>+{
>+  const gchar **iter;
>+
>+  for (iter = implemented_interfaces + HAZE_NUM_CONDITIONAL_INTERFACES;
>+      *iter != NULL; iter++)
>+    g_ptr_array_add (interfaces, (gchar *) *iter);
>+}
>+
> static GPtrArray *
> haze_connection_get_interfaces_always_present (TpBaseConnection *base)
> {
>   GPtrArray *interfaces;
>-  const gchar **iter;
> 
>   interfaces = TP_BASE_CONNECTION_CLASS (
>       haze_connection_parent_class)->get_interfaces_always_present (base);
> 
>-  for (iter = implemented_interfaces + HAZE_NUM_CONDITIONAL_INTERFACES;
>-      *iter != NULL; iter++)
>-    g_ptr_array_add (interfaces, (gchar *) *iter);
>+  add_always_present_connection_interfaces (interfaces);
> 
>   return interfaces;
> }
>-- 
>1.8.3.1
>

Actions: View | Splinter Review

Attachments on bug 69466: 85977 | 85978 | 85979 | 85980 | 85981 | 85986 | 85991 | 86039 | 86059

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.