Attachment 86721 Details for Bug 69717 – fix ps font embedding

[patch] fix ps font embedding

0001-Fix-PS-output-when-substituting-a-Type-1-PFB-font.patch (text/plain), 2.62 KB, created by Adrian Johnson on 2013-09-27 12:27:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Adrian Johnson

Created: 2013-09-27 12:27:25 UTC

Size: 2.62 KB

patch

obsolete

>From b5bf14c2c191a22897f444dab34df136ff919bba Mon Sep 17 00:00:00 2001
>From: Adrian Johnson <ajohnson@redneon.com>
>Date: Fri, 27 Sep 2013 21:53:53 +0930
>Subject: [PATCH] Fix PS output when substituting a Type 1 PFB font
>
>Bug 69717
>---
> poppler/PSOutputDev.cc |   50 +++++++++++++++++++++++++++++++++++++++++++-----
> 1 file changed, 45 insertions(+), 5 deletions(-)
>
>diff --git a/poppler/PSOutputDev.cc b/poppler/PSOutputDev.cc
>index 4fe5d7b..f3fa62d 100644
>--- a/poppler/PSOutputDev.cc
>+++ b/poppler/PSOutputDev.cc
>@@ -1842,9 +1842,9 @@ void PSOutputDev::setupFont(GfxFont *font, Dict *parentResDict) {
> 	//~ add cases for external 16-bit fonts
> 	switch (fontLoc->fontType) {
> 	case fontType1:
>-	  if (font->getName()) {
>+	  if (font->getEmbeddedFontName()) {
> 	    // this assumes that the PS font name matches the PDF font name
>-	    psName = font->getName()->copy();
>+	    psName = font->getEmbeddedFontName()->copy();
> 	  } else {
> 	    //~ this won't work -- the PS font name won't match
> 	    psName = makePSFontName(font, font->getID());
>@@ -2140,9 +2140,8 @@ void PSOutputDev::setupEmbeddedType1Font(Ref *id, GooString *psName) {
>   strObj.free();
> }
> 
>-//~ This doesn't handle .pfb files or binary eexec data (which only
>-//~ happens in pfb files?).
> void PSOutputDev::setupExternalType1Font(GooString *fileName, GooString *psName) {
>+  static const char hexChar[17] = "0123456789abcdef";
>   FILE *fontFile;
>   int c;
> 
>@@ -2162,8 +2161,49 @@ void PSOutputDev::setupExternalType1Font(GooString *fileName, GooString *psName)
>     error(errIO, -1, "Couldn't open external font file");
>     return;
>   }
>-  while ((c = fgetc(fontFile)) != EOF) {
>+
>+  c = fgetc(fontFile);
>+  if (c == 0x80) {
>+    // PFB file
>+    ungetc(c, fontFile);
>+    while (!feof(fontFile)) {
>+      fgetc(fontFile); // skip start of segment byte (0x80)
>+      int segType = fgetc(fontFile);
>+      long segLen = fgetc(fontFile) |
>+	(fgetc(fontFile) << 8) |
>+	(fgetc(fontFile) << 16) |
>+	(fgetc(fontFile) << 24);
>+      if (feof(fontFile))
>+	break;
>+
>+      if (segType == 1) {
>+	// ASCII segment
>+	for (long i = 0; i < segLen; i++) {
>+	  c = fgetc(fontFile);
>+	  if (c == EOF)
>+	    break;
>+	  writePSChar(c);
>+	}
>+      } else if (segType == 2) {
>+	// binary segment
>+	for (long i = 0; i < segLen; i++) {
>+	  c = fgetc(fontFile);
>+	  if (c == EOF)
>+	    break;
>+	  writePSChar(hexChar[(c >> 4) & 0x0f]);
>+	  writePSChar(hexChar[c & 0x0f]);
>+	  if (i % 36 == 35)
>+	    writePSChar('\n');
>+	}
>+      } else {
>+	// end of file
>+	break;
>+      }
>+    }
>+  } else if (c != EOF) {
>     writePSChar(c);
>+    while ((c = fgetc(fontFile)) != EOF)
>+      writePSChar(c);
>   }
>   fclose(fontFile);
> 
>-- 
>1.7.10.4
>

Actions: View | Splinter Review

Attachments on bug 69717: 86377 | 86378 | 86379 | 86721

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.