Attachment 88354 Details for Bug 71048 – 08/15] TpPresenceMixin: deprecate optional arguments other than "message"

[patch] 08/15] TpPresenceMixin: deprecate optional arguments other than "message"

0008-TpPresenceMixin-deprecate-optional-arguments-other-t.patch (text/plain), 2.24 KB, created by Simon McVittie on 2013-10-30 12:56:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2013-10-30 12:56:56 UTC

Size: 2.24 KB

patch

obsolete

>From 3666a97436a0d17e482bb33f3c3a23f43576d05d Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Mon, 28 Oct 2013 14:51:55 +0000
>Subject: [PATCH 08/15] TpPresenceMixin: deprecate optional arguments other
> than "message"
>
>Our D-Bus API no longer supports anything else.
>---
> telepathy-glib/presence-mixin.c | 16 ++++++++++++++--
> 1 file changed, 14 insertions(+), 2 deletions(-)
>
>diff --git a/telepathy-glib/presence-mixin.c b/telepathy-glib/presence-mixin.c
>index e954b47..141dda8 100644
>--- a/telepathy-glib/presence-mixin.c
>+++ b/telepathy-glib/presence-mixin.c
>@@ -131,7 +131,10 @@
>  * @optional_arguments: An array of #TpPresenceStatusOptionalArgumentSpec
>  *  structures representing the optional arguments for this status, terminated
>  *  by a NULL name. If there are no optional arguments for a status, this can
>- *  be NULL.
>+ *  be NULL. In modern Telepathy connection managers, the only optional
>+ *  argument should be a string (type "s") named "message" on statuses
>+ *  that have an optional human-readable message. All other optional arguments
>+ *  are deprecated.
>  *
>  * Structure specifying a supported presence status.
>  *
>@@ -153,9 +156,13 @@
>  * In addition to the fields documented here, there are two gpointer fields
>  * which must currently be %NULL. A meaning may be defined for these in a
>  * future version of telepathy-glib.
>+ *
>+ * In modern Telepathy connection managers, the only optional
>+ * argument should be a %G_TYPE_STRING named "message", on statuses
>+ * that have an optional human-readable message. All other optional arguments
>+ * are deprecated.
>  */
> 
>-
> /**
>  * TpPresenceMixinStatusAvailableFunc:
>  * @obj: An instance of a #TpBaseConnection subclass implementing the presence
>@@ -333,6 +340,11 @@ deep_copy_hashtable (GHashTable *hash_table)
>  * Construct a presence status structure. You should free the returned
>  * structure with #tp_presence_status_free.
>  *
>+ * In modern Telepathy connection managers, the only optional
>+ * argument should be a %G_TYPE_STRING named "message", on statuses
>+ * that have an optional human-readable message. All other optional arguments
>+ * are deprecated.
>+ *
>  * Returns: A pointer to the newly allocated presence status structure.
>  */
> TpPresenceStatus *
>-- 
>1.8.4.rc3
>

Actions: View | Splinter Review

Attachments on bug 71048: 88347 | 88348 | 88349 | 88350 | 88351 | 88352 | 88353 | 88354 | 88355 | 88356 | 88357 | 88358 | 88359 | 88360 | 88361 | 89036 | 89037

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.