Attachment 89229 Details for Bug 27727 – 22/26] dbus-account-plugin: update internal cache correctly

[patch] 22/26] dbus-account-plugin: update internal cache correctly

0022-dbus-account-plugin-update-internal-cache-correctly.patch (text/plain), 1.19 KB, created by Simon McVittie on 2013-11-14 18:18:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2013-11-14 18:18:05 UTC

Size: 1.19 KB

patch

obsolete

>From 468ea6c6d2cc23ec452c9b4da63f91b63b961e70 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Thu, 14 Nov 2013 16:29:02 +0000
>Subject: [PATCH 22/26] dbus-account-plugin: update internal cache correctly
>
>The backend-makes-changes test replaces an typed parameter with an
>untyped parameter. We correctly signalled the change to MC,
>but didn't update the internal cache; the rather strange way in
>which MC receives attributes/parameters masked this bug.
>---
> tests/twisted/dbus-account-plugin.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/tests/twisted/dbus-account-plugin.c b/tests/twisted/dbus-account-plugin.c
>index e43d40e..7eaccc3 100644
>--- a/tests/twisted/dbus-account-plugin.c
>+++ b/tests/twisted/dbus-account-plugin.c
>@@ -581,6 +581,7 @@ test_dbus_account_plugin_process_parameters (TestDBusAccountPlugin *self,
>               (stored == NULL ||
>                !g_variant_equal (value, stored)))
>             {
>+              g_hash_table_remove (account->parameters, param);
>               g_hash_table_insert (account->untyped_parameters,
>                   g_strdup (param), g_strdup (escaped));
>               key = g_strdup_printf ("param-%s", param);
>-- 
>1.8.4.3
>

Actions: View | Splinter Review

Attachments on bug 27727: 35148 | 89208 | 89209 | 89210 | 89211 | 89212 | 89213 | 89214 | 89215 | 89216 | 89217 | 89218 | 89219 | 89220 | 89221 | 89222 | 89223 | 89224 | 89225 | 89226 | 89227 | 89228 | 89229 | 89230 | 89231 | 89232 | 89233 | 89237

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.