Attachment 89262 Details for Bug 71641 – Fix warning on signed/unsigned comparison in GfxState.cc

Fix warning on signed/unsigned comparison in GfxState.cc

0001-Fix-warning-on-signed-unsigned-comparison-in-GfxStat.patch (text/plain), 1.78 KB, created by Hib Eris on 2013-11-15 11:43:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Hib Eris

Created: 2013-11-15 11:43:36 UTC

Size: 1.78 KB

patch

obsolete

>From c436b28807f3ee0a896380899346cc103798b33d Mon Sep 17 00:00:00 2001
>From: Hib Eris <hib@hiberis.nl>
>Date: Fri, 15 Nov 2013 11:10:13 +0100
>Subject: [PATCH] Fix warning on signed/unsigned comparison in GfxState.cc
>
>Fixes warning:
>
>  CXX    GfxState.lo
>GfxState.cc: In member function 'virtual void GfxICCBasedColorSpace::getGray(GfxColor*, GfxGray*)':
>GfxState.cc:2000:43: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
>GfxState.cc: In member function 'virtual void GfxICCBasedColorSpace::getRGB(GfxColor*, GfxRGB*)':
>GfxState.cc:2047:43: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
>GfxState.cc:2090:43: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
>GfxState.cc: In member function 'virtual void GfxICCBasedColorSpace::getCMYK(GfxColor*, GfxCMYK*)':
>GfxState.cc:2295:43: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
>---
> poppler/GfxState.cc | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/poppler/GfxState.cc b/poppler/GfxState.cc
>index 8a53ee4..68b4a37 100644
>--- a/poppler/GfxState.cc
>+++ b/poppler/GfxState.cc
>@@ -25,6 +25,7 @@
> // Copyright (C) 2011 Andrea Canciani <ranma42@gmail.com>
> // Copyright (C) 2012 William Bader <williambader@hotmail.com>
> // Copyright (C) 2013 Lu Wang <coolwanglu@gmail.com>
>+// Copyright (C) 2013 Hib Eris <hib@hiberis.nl>
> //
> // To see a description of the changes please see the Changelog file that
> // came with your tarball or type make ChangeLog if you are building from git
>@@ -156,7 +157,7 @@ static const char *gfxColorSpaceModeNames[] = {
> 
> #ifdef USE_CMS
> 
>-static const int CMSCACHE_LIMIT = 2048;
>+static const unsigned int CMSCACHE_LIMIT = 2048;
> 
> #ifdef USE_LCMS1
> #include <lcms.h>
>-- 
>1.8.1.2
>

Actions: View

Attachments on bug 71641: 89262 | 89310

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.