Attachment 90567 Details for Bug 72562 – [PATCH 3/5] udev: udev_hwdb_new: document unused parameter

[patch] [PATCH 3/5] udev: udev_hwdb_new: document unused parameter

0003-udev-udev_hwdb_new-document-unused-parameter.patch (text/plain), 1.85 KB, created by Allison Lortie (desrt) on 2013-12-10 12:23:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Allison Lortie (desrt)

Created: 2013-12-10 12:23:14 UTC

Size: 1.85 KB

patch

obsolete

>From de85b2b65e4f05ec3fe04a881cb6c92694aea8f8 Mon Sep 17 00:00:00 2001
>From: Ryan Lortie <desrt@desrt.ca>
>Date: Tue, 10 Dec 2013 06:30:56 -0500
>Subject: [PATCH 3/5] udev: udev_hwdb_new: document unused parameter
>
>Rename the 'udev' parameter to 'unused' and document that it is ignored.
>Also, change its type to void *.  We cannot remove the parameter here
>because this is public API.
>
>https://bugs.freedesktop.org/show_bug.cgi?id=72562
>---
> src/libudev/libudev-hwdb.c | 4 ++--
> src/libudev/libudev.h      | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/src/libudev/libudev-hwdb.c b/src/libudev/libudev-hwdb.c
>index 5a62e27..5c1a634 100644
>--- a/src/libudev/libudev-hwdb.c
>+++ b/src/libudev/libudev-hwdb.c
>@@ -258,13 +258,13 @@ static int trie_search_f(struct udev_hwdb *hwdb, const char *search) {
> 
> /**
>  * udev_hwdb_new:
>- * @udev: udev library context
>+ * @unused: ignored
>  *
>  * Create a hardware database context to query properties for devices.
>  *
>  * Returns: a hwdb context.
>  **/
>-_public_ struct udev_hwdb *udev_hwdb_new(struct udev *udev) {
>+_public_ struct udev_hwdb *udev_hwdb_new(void *unused) {
>         struct udev_hwdb *hwdb;
>         const char sig[] = HWDB_SIG;
> 
>diff --git a/src/libudev/libudev.h b/src/libudev/libudev.h
>index b9b8f13..8c4fc7a 100644
>--- a/src/libudev/libudev.h
>+++ b/src/libudev/libudev.h
>@@ -185,7 +185,7 @@ struct udev_list_entry *udev_queue_get_queued_list_entry(struct udev_queue *udev
>  *  access to the static hardware properties database
>  */
> struct udev_hwdb;
>-struct udev_hwdb *udev_hwdb_new(struct udev *udev);
>+struct udev_hwdb *udev_hwdb_new(void *unused);
> struct udev_hwdb *udev_hwdb_ref(struct udev_hwdb *hwdb);
> struct udev_hwdb *udev_hwdb_unref(struct udev_hwdb *hwdb);
> struct udev_list_entry *udev_hwdb_get_properties_list_entry(struct udev_hwdb *hwdb, const char *modalias, unsigned int flags);
>-- 
>1.8.4.2
>

Actions: View | Splinter Review

Attachments on bug 72562: 90565 | 90566 | 90567 | 90568 | 90569

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.