Attachment 92877 Details for Bug 72312 – 0008 ensure there is always a valid page size in the output

[patch] 0008 ensure there is always a valid page size in the output

0008-pdftops-ensure-there-is-always-a-page-size-in-the-ou.patch (text/plain), 1.07 KB, created by Adrian Johnson on 2014-01-27 19:39:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Adrian Johnson

Created: 2014-01-27 19:39:14 UTC

Size: 1.07 KB

patch

obsolete

>From 9c1fd9bd11710b9e1797718a31db5192c1ac8fb4 Mon Sep 17 00:00:00 2001
>From: Adrian Johnson <ajohnson@redneon.com>
>Date: Tue, 28 Jan 2014 06:06:09 +1030
>Subject: [PATCH 8/8] pdftops: ensure there is always a page size in the output
>
>even if the PDF file as badly broken.
>---
> poppler/PSOutputDev.cc | 7 +++++++
> 1 file changed, 7 insertions(+)
>
>diff --git a/poppler/PSOutputDev.cc b/poppler/PSOutputDev.cc
>index 34b7cbd..a85fc24 100644
>--- a/poppler/PSOutputDev.cc
>+++ b/poppler/PSOutputDev.cc
>@@ -1257,6 +1257,13 @@ void PSOutputDev::init(PSOutputFunc outputFuncA, void *outputStreamA,
>     if (!paperMatch) {
>       w = paperWidth;
>       h = paperHeight;
>+      if (w < 0 || h < 0) {
>+        // Unable to obtain a paper size from the document and no page size
>+        // specified. In this case use A4 as the page size to ensure the PS output is
>+        // valid. This will only occur if the PDF is very broken.
>+        w = 595;
>+        h = 842;
>+      }
>     } else if (noCropA) {
>       w = (int)ceil(page->getMediaWidth());
>       h = (int)ceil(page->getMediaHeight());
>-- 
>1.8.3.2
>

Actions: View | Splinter Review

Attachments on bug 72312: 90227 | 90228 | 90229 | 90232 | 90792 | 90793 | 90794 | 90835 | 90836 | 90837 | 91000 | 91002 | 91003 | 91004 | 91005 | 91064 | 91104 | 91266 | 91314 | 91315 | 92877

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.