Attachment 93794 Details for Bug 74805 – Tagged-PDF: Fix parsing of attached element attributes

[patch] Tagged-PDF: Fix parsing of attached element attributes

0001-Tagged-PDF-Fix-parsing-of-attached-element-attribute.patch (text/plain), 1.19 KB, created by Adrian Perez de Castro on 2014-02-10 18:32:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Adrian Perez de Castro

Created: 2014-02-10 18:32:38 UTC

Size: 1.19 KB

patch

obsolete

>From 3c65d810eefe4e97bed790d7a49772311ae6de8d Mon Sep 17 00:00:00 2001
>From: Adrian Perez de Castro <aperez@igalia.com>
>Date: Mon, 10 Feb 2014 20:29:35 +0200
>Subject: [PATCH] Tagged-PDF: Fix parsing of attached element attributes
>
>The wrong object was used as attribute dictionary, which caused
>a segmentation fault when parsing PDF files in which the structure
>elements included attributes attached to them. This patch fixes the
>issue.
>
>Thanks to Joanmarie Diggs <jdiggs@igalia.com> for helping in
>debugging the problem.
>---
> poppler/StructElement.cc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/poppler/StructElement.cc b/poppler/StructElement.cc
>index c3724b8..ba859e9 100644
>--- a/poppler/StructElement.cc
>+++ b/poppler/StructElement.cc
>@@ -1158,7 +1158,7 @@ void StructElement::parse(Dict *element)
>     for (int i = 0; i < obj.arrayGetLength(); i++) {
>       if (obj.arrayGet(i, &iobj)->isDict()) {
>         attrIndex = getNumAttributes();
>-        parseAttributes(obj.getDict());
>+        parseAttributes(iobj.getDict());
>       } else if (iobj.isInt()) {
>         const int revision = iobj.getInt();
>         // Set revision numbers for the elements previously created.
>-- 
>1.8.5.4
>

Actions: View | Splinter Review

Attachments on bug 74805: 93793 | 93794

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.