Attachment 94662 Details for Bug 75001 – drm/i915: use legacy combination mode also for i945gm

[patch] drm/i915: use legacy combination mode also for i945gm

0001-drm-i915-use-legacy-combination-mode-also-for-i945gm.patch (text/plain), 1.43 KB, created by Jani Nikula on 2014-02-24 15:30:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jani Nikula

Created: 2014-02-24 15:30:48 UTC

Size: 1.43 KB

patch

obsolete

>From d8258bce470300f7882510e14741d1993648ab2d Mon Sep 17 00:00:00 2001
>From: Jani Nikula <jani.nikula@intel.com>
>Date: Mon, 24 Feb 2014 17:32:01 +0200
>Subject: [PATCH] drm/i915: use legacy combination mode also for i945gm
>Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
>Cc: Jani Nikula <jani.nikula@intel.com>
>
>i945gm also seems to use and need the legacy combination mode bit in
>BLC_PWM_CTL.
>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=75001
>Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>---
> drivers/gpu/drm/i915/intel_panel.c |    4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c
>index 350de359123a..8d774ffbeed2 100644
>--- a/drivers/gpu/drm/i915/intel_panel.c
>+++ b/drivers/gpu/drm/i915/intel_panel.c
>@@ -698,7 +698,7 @@ static void i9xx_enable_backlight(struct intel_connector *connector)
> 		freq /= 0xff;
> 
> 	ctl = freq << 17;
>-	if (IS_GEN2(dev) && panel->backlight.combination_mode)
>+	if (panel->backlight.combination_mode)
> 		ctl |= BLM_LEGACY_MODE;
> 	if (IS_PINEVIEW(dev) && panel->backlight.active_low_pwm)
> 		ctl |= BLM_POLARITY_PNV;
>@@ -979,7 +979,7 @@ static int i9xx_setup_backlight(struct intel_connector *connector)
> 
> 	ctl = I915_READ(BLC_PWM_CTL);
> 
>-	if (IS_GEN2(dev))
>+	if (IS_GEN2(dev) || IS_I945GM(dev))
> 		panel->backlight.combination_mode = ctl & BLM_LEGACY_MODE;
> 
> 	if (IS_PINEVIEW(dev))
>-- 
>1.7.9.5
>

Actions: View | Splinter Review

Attachments on bug 75001: 94098 | 94099 | 94662

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.