Attachment 97120 Details for Bug 76276 – 2/2 drm/i915: do not setup backlight if not available according to VBT

[patch] 2/2 drm/i915: do not setup backlight if not available according to VBT

0002-drm-i915-do-not-setup-backlight-if-not-available-acc.patch (text/plain), 1.79 KB, created by Jani Nikula on 2014-04-09 08:45:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jani Nikula

Created: 2014-04-09 08:45:43 UTC

Size: 1.79 KB

patch

obsolete

>From 536d1074f522f3b7c2e71abb3d987957ea24dfd4 Mon Sep 17 00:00:00 2001
>From: Jani Nikula <jani.nikula@intel.com>
>Date: Wed, 9 Apr 2014 11:31:37 +0300
>Subject: [PATCH 2/2] drm/i915: do not setup backlight if not available
> according to VBT
>Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
>Cc: Jani Nikula <jani.nikula@intel.com>
>
>Some machines use an external EC for controlling the backlight. Info
>about this is present in the VBT. Do not setup native backlight control
>if no PWM backlight is available or supported according to VBT.
>
>In most cases there has been no harm done, but it looks like there are
>machines out there that have both an EC and our PWM line connected to
>the same wire.
>
>This should fix the regression caused by
>commit bc0bb9fd1c7810407ab810d204bbaecb255fddde
>Author: Jani Nikula <jani.nikula@intel.com>
>Date:   Thu Nov 14 12:14:29 2013 +0200
>
>    drm/i915: remove QUIRK_NO_PCH_PWM_ENABLE
>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=76276
>Reference: https://bugzilla.kernel.org/show_bug.cgi?id=47941
>Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>---
> drivers/gpu/drm/i915/intel_panel.c |    5 +++++
> 1 file changed, 5 insertions(+)
>
>diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c
>index cb058408c70e..0eead16aeda7 100644
>--- a/drivers/gpu/drm/i915/intel_panel.c
>+++ b/drivers/gpu/drm/i915/intel_panel.c
>@@ -1065,6 +1065,11 @@ int intel_panel_setup_backlight(struct drm_connector *connector)
> 	unsigned long flags;
> 	int ret;
> 
>+	if (!dev_priv->vbt.backlight.present) {
>+		DRM_DEBUG_KMS("native backlight control not available per VBT\n");
>+		return 0;
>+	}
>+
> 	/* set level and max in panel struct */
> 	spin_lock_irqsave(&dev_priv->backlight_lock, flags);
> 	ret = dev_priv->display.setup_backlight(intel_connector);
>-- 
>1.7.9.5
>

Actions: View | Splinter Review

Attachments on bug 76276: 95952 | 95953 | 95954 | 96374 | 96375 | 97111 | 97119 | 97120

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.