Attachment 97220 Details for Bug 77298 – suggested fix.

[patch] suggested fix.

fix_for_fdo77298.patch (text/plain), 1.04 KB, created by Jürgen Weigert on 2014-04-11 12:43:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jürgen Weigert

Created: 2014-04-11 12:43:41 UTC

Size: 1.04 KB

patch

obsolete

>diff --git a/src/cairo-pen.c b/src/cairo-pen.c
>index 61be0e8..8eed775 100644
>--- a/src/cairo-pen.c
>+++ b/src/cairo-pen.c
>@@ -284,7 +284,20 @@ _cairo_pen_vertices_needed (double	    tolerance,
> 								     radius);
>     int num_vertices;
> 
>-    if (tolerance >= 4*major_axis) { /* XXX relaxed from 2*major for inkscape */
>+    if (tolerance >= 100*major_axis) { /* XXX relaxed from 2*major for inkscape */
>+	/*
>+         * When we decide for num_vertices = 1, the object is not drawn.
>+	 * To avoid https://bugs.freedesktop.org/show_bug.cgi?id=77298
>+	 * we use 100*major -- this just helps us to the 0.001mm line width.
>+	 *
>+	 * The author of the 'XXX relaxed' comment above, originally used 4*major,
>+	 * which is not sufficient for my inkscape lasercutter usecase.
>+	 *
>+	 * Please double check if num_vertices == 1 should never be done (for PDF).
>+	 *
>+	 * jnweiger@gmail.com
>+	 */
>+	// fprintf(stderr, "tolerance=%g major_axis=%g -> num_vertices = 1\n", tolerance, major_axis);
> 	num_vertices = 1;
>     } else if (tolerance >= major_axis) {
> 	num_vertices = 4;

Actions: View | Splinter Review

Attachments on bug 77298: 97205 | 97206 | 97207 | 97220 | 97247 | 118380 | 118381 | 118385

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.