Attachment 99312 Details for Bug 58727 – Fix warn_unused_result warnings from gcc - 2nd approach

[patch] Fix warn_unused_result warnings from gcc - 2nd approach

0001-src-Fix-warn_unused_result-warnings-from-gcc.patch (text/plain), 2.38 KB, created by Ravi Nanjundappa on 2014-05-19 09:31:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ravi Nanjundappa

Created: 2014-05-19 09:31:16 UTC

Size: 2.38 KB

patch

obsolete

>From 7c95ebdb5571573112f98b3ae6fbdeadc2d60c5c Mon Sep 17 00:00:00 2001
>From: Ravi Nanjundappa <nravi.n@samsung.com>
>Date: Mon, 19 May 2014 14:59:29 +0530
>Subject: [PATCH] src : Fix warn_unused_result warnings from gcc
>
>Fix 'unused-result' warning messages by
>- replacing cairo_private to cairo_private_no_warn in the
>  declaration of the cairo private apis '_cairo_surface_unmap_image',
>  '_cairo_polygon_add_line', '_cairo_polygon_add_external_edge' and
>  '_cairo_polygon_add_contour'
>- removing cairo_warn for 'render_rows' member function pointer in
>  'struct _cairo_span_renderer'
>
>Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
>---
> src/cairo-spans-private.h |    2 +-
> src/cairoint.h            |    8 ++++----
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
>diff --git a/src/cairo-spans-private.h b/src/cairo-spans-private.h
>index c42b5af..b158f4d 100644
>--- a/src/cairo-spans-private.h
>+++ b/src/cairo-spans-private.h
>@@ -53,7 +53,7 @@ struct _cairo_span_renderer {
> 
>     /* Render the spans on row y of the destination by whatever compositing
>      * method is required. */
>-    cairo_warn cairo_status_t
>+    cairo_status_t
>     (*render_rows) (void *abstract_renderer,
> 		    int y, int height,
> 		    const cairo_half_open_span_t	*coverages,
>diff --git a/src/cairoint.h b/src/cairoint.h
>index 44e0ec5..080bb5d 100644
>--- a/src/cairoint.h
>+++ b/src/cairoint.h
>@@ -1321,7 +1321,7 @@ cairo_private cairo_image_surface_t *
> _cairo_surface_map_to_image (cairo_surface_t  *surface,
> 			     const cairo_rectangle_int_t *extents);
> 
>-cairo_private cairo_int_status_t
>+cairo_private_no_warn cairo_int_status_t
> _cairo_surface_unmap_image (cairo_surface_t       *surface,
> 			    cairo_image_surface_t *image);
> 
>@@ -1609,18 +1609,18 @@ _cairo_polygon_limit_to_clip (cairo_polygon_t *polygon,
> cairo_private void
> _cairo_polygon_fini (cairo_polygon_t *polygon);
> 
>-cairo_private cairo_status_t
>+cairo_private_no_warn cairo_status_t
> _cairo_polygon_add_line (cairo_polygon_t *polygon,
> 			 const cairo_line_t *line,
> 			 int top, int bottom,
> 			 int dir);
> 
>-cairo_private cairo_status_t
>+cairo_private_no_warn cairo_status_t
> _cairo_polygon_add_external_edge (void *polygon,
> 				  const cairo_point_t *p1,
> 				  const cairo_point_t *p2);
> 
>-cairo_private cairo_status_t
>+cairo_private_no_warn cairo_status_t
> _cairo_polygon_add_contour (cairo_polygon_t *polygon,
> 			    const cairo_contour_t *contour);
> 
>-- 
>1.7.9.5
>

Actions: View | Splinter Review

Attachments on bug 58727: 98546 | 99012 | 99312

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.