Bug 3377 - _glapi_add_entrypoint does not function properly for offset ~0
Summary: _glapi_add_entrypoint does not function properly for offset ~0
Status: RESOLVED FIXED
Alias: None
Product: DRI
Classification: Unclassified
Component: libGL (show other bugs)
Version: DRI git
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: Default DRI bug account
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 1690 3378
  Show dependency tree / graph
 
Reported: 2005-05-23 13:49 UTC by Ian Romanick
Modified: 2005-08-04 18:38 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Generate dynamic offsets, handle GLuint ~0 values properly (6.68 KB, patch)
2005-05-23 16:13 UTC, Ian Romanick 		no flags Details | Splinter Review
View All

Description Ian Romanick 2005-05-23 13:49:56 UTC 
When an offset of ~0 is passed to _glapi_add_entrypoint, it is supposed to
generate a dispatch stub and insert it in the internal table.  However, because
offset is GLuint, the test "offset >= DISPATCH_TABLE_SIZE" will always fail and
the function will return GL_FALSE.
Comment 1 Ian Romanick 2005-05-23 16:13:43 UTC 
Created attachment 2753 [details] [review]
Generate dynamic offsets, handle GLuint ~0 values properly

This patch *completely* re-works _glapi_add_entrypoint.  Dispatch offsets are
now correctly assigned and all of the GLint vs. GLuint issues should be
resolved.  This patch /should/ fix this bug and bug #3378.
Comment 2 Ian Romanick 2005-08-06 04:38:21 UTC 
_glapi_add_entrypoint has been removed from the API.  It has been replaced with
_glapi_add_dispatch.  I am closing #3377 and #3378 as fixed.  Any problems
discovered in this new API should have new bugs filed for them.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.