Bug 92538: GLib-based tests built for Windows don't work under Wine - Simon McVittie <smcv@collabora.com> - 10/19/2015 Back to Bug | Your Reviews | Help
Attachment 118983: [4/4] refs test: reduce number of repeats under Wine - Simon McVittie <smcv@collabora.com> - 10/19/2015 (View )

Show Quick Help

From: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: Mon, 19 Oct 2015 16:04:40 +0100
Subject: [PATCH 6/6] refs test: reduce number of repeats under Wine
Under Wine, the API calls we use to do this are implemented via IPC
to wineserver, which makes it unreasonably slow to try to brute-force
bugs by having many threads stress-test refcounting. Do a few
repetitions just to verify that refcounting basically works, but
don't do the full stress-test.
---
test/internals/refs.c | 99 ++++++++++++++++++++++++++++++++++-----------------
1 file changed, 67 insertions(+), 32 deletions(-)
<Overall Comment>
Previous Reviews
Ralf Habacker <ralf.habacker@freenet.de>
10/22/2015
-----------------------------------------------------------------
test/internals/refs.c
208 
209 f->n_threads = N_THREADS;
210 f->n_refs = N_REFS;
211 
212 if (g_getenv ("WINESERVERSOCKET") != NULL)
I guess this environment variable is for detecting if dbus is running under wine. This can be automated by checking the presence of a dedicated registry key for example HKCU/Software/Wine/Debug http://wiki.winehq.org/UsefulRegistryKeys
Ralf Habacker <ralf.habacker@freenet.de>
10/27/2015
-----------------------------------------------------------------
looks good
test/internals/refs.c
I guess this environment variable is for detecting if dbus is running under wine. This can be automated by checking the presence of a dedicated registry key for example HKCU/Software/Wine/Debug http://wiki.winehq.org/UsefulRegistryKeys
Using WINESERVERSOCKET looks good. Would be nice to have a note in the doc that WINESERVERSOCKET is set by wine for child processes.
Powered by Splinter

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.