Bug 92721:
bus-test and dbus-test failure on cross compile for windows -
Ralf Habacker <ralf.habacker@freenet.de> -
10/29/2015
Back to Bug |
Your Reviews |
Help
Attachment 119530:
Do not use dbus_warn for skipping unit tests on windows to avoid fatal errors. -
Ralf Habacker <ralf.habacker@freenet.de> -
11/10/2015
(
View
)
Close Quick Help
- From the Overview page, you can add a more generic overview comment that will appear at the beginning of your review.
- To comment on a specific lines in the patch, first select the filename from the file navigation links.
- Then double click the line you want to review and a comment box will appear below the line.
- When the review is complete and you publish it, the overview comment and all line specific comments with their context,
will be combined together into a single review comment on the bug report.
- For more detailed instructions, read the Splinter
help page.
From: Ralf Habacker <ralf.habacker@freenet.de>
Date: Tue, 10 Nov 2015 08:43:16 +0100
Subject: [PATCH] Do not use dbus_warn for skipping unit tests on windows to
avoid fatal errors.
---
bus/dispatch.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
(Restored from draft; last edited )
Previous Reviews
Simon McVittie <smcv@collabora.com>
11/11/2015
-----------------------------------------------------------------
OK. It would also be OK to skip testing the launch helper without any comment at all: it makes no sense on Windows (the system bus is unsupported there, and I don't think Windows has any concept of setuid binaries, so it can't ever actually work).