Bug 93069:
clean up compiler warnings from gcc 5.2 -
Ralf Habacker <ralf.habacker@freenet.de> -
11/22/2015
Back to Bug |
Your Reviews |
Help
Attachment 120023:
Fix warning: "pointer targets in passing argument 2 of '_dbus_unpack_uint32' differ in signedness [-Wpointer-sign]". -
Ralf Habacker <ralf.habacker@freenet.de> -
11/22/2015
(
View
)
Close Quick Help
- From the Overview page, you can add a more generic overview comment that will appear at the beginning of your review.
- To comment on a specific lines in the patch, first select the filename from the file navigation links.
- Then double click the line you want to review and a comment box will appear below the line.
- When the review is complete and you publish it, the overview comment and all line specific comments with their context,
will be combined together into a single review comment on the bug report.
- For more detailed instructions, read the Splinter
help page.
From: Ralf Habacker <ralf.habacker@freenet.de>
Date: Sun, 22 Nov 2015 19:54:15 +0100
Subject: [PATCH 4/4] Fix warning: "pointer targets in passing argument 2 of
'_dbus_unpack_uint32' differ in signedness [-Wpointer-sign]".
Bug: https://bugs.freedesktop.org/attachment.cgi?id=120019
(Restored from draft; last edited )
Previous Reviews
Simon McVittie <smcv@collabora.com>
11/23/2015
-----------------------------------------------------------------
OK.
I wonder whether we should have
static inline const unsigned char *
_dbus_string_get_const_udata (const DBusString *str)
{
return (const unsigned char *) _dbus_string_get_const_data (str);
}
and the same for _dbus_string_get_const_data_len, and maybe even their non-const equivalents if it would be useful.