Bug 93069:
clean up compiler warnings from gcc 5.2 -
Ralf Habacker <ralf.habacker@freenet.de> -
11/22/2015
Back to Bug |
Your Reviews |
Help
Attachment 121660:
Refactored cmake part dealing with compiler warnings to use warnings identifier (update 2) -
Ralf Habacker <ralf.habacker@freenet.de> -
2/11/2016
(
View
)
Close Quick Help
- From the Overview page, you can add a more generic overview comment that will appear at the beginning of your review.
- To comment on a specific lines in the patch, first select the filename from the file navigation links.
- Then double click the line you want to review and a comment box will appear below the line.
- When the review is complete and you publish it, the overview comment and all line specific comments with their context,
will be combined together into a single review comment on the bug report.
- For more detailed instructions, read the Splinter
help page.
From: Ralf Habacker <ralf.habacker@freenet.de>
Date: Thu, 26 Nov 2015 15:00:59 +0100
Subject: [PATCH 1/3] Refactored cmake part dealing with compiler warnings to
use warnings identifier.
It is now possible to use msvc warnings identifiers
(e.g. '4114') or gcc warnings keys (e.g. 'pointer-sign').
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=93069
(Restored from draft; last edited )
Previous Reviews
Simon McVittie <smcv@collabora.com>
2/11/2016
-----------------------------------------------------------------
Looks good, thanks.
cmake/CMakeLists.txt