Bug 106339: [PATCH] bus: Mark service as requiring nss-user-lookup.target - Jonathan Lebon <jonathan@jlebon.com> - 5/1/2018 Back to Bug | Your Reviews | Help
Attachment 139254: bus: Mark service as requiring nss-user-lookup.target - Jonathan Lebon <jonathan@jlebon.com> - 5/1/2018 (View )

Show Quick Help

From: Jonathan Lebon <jonathan@jlebon.com>
Date: Tue, 1 May 2018 14:01:26 -0400
Subject: [PATCH] bus: Mark service as requiring nss-user-lookup.target
D-Bus needs to be able to resolve usernames when reading message bus
configuration files. Thus, it should be ordered *after* the special
`nss-user-lookup.target`, which is a synchronization points for units
that provide/require lookup services.
---
bus/dbus.service.in | 2 ++
1 file changed, 2 insertions(+)
<Overall Comment>
Previous Reviews
Simon McVittie <smcv@collabora.com>
5/1/2018
-----------------------------------------------------------------
bus/dbus.service.in
2Description=D-Bus System Message Bus
3Documentation=man:dbus-daemon(1)
4Requires=dbus.socket
5After=nss-user-lookup.target
After= seems fine.
2Description=D-Bus System Message Bus
3Documentation=man:dbus-daemon(1)
4Requires=dbus.socket
5After=nss-user-lookup.target
6Requires=nss-user-lookup.target
I'm not so sure about Requires=.
How recent is that target? Can we assume that it exists on every systemd-using OS? (New dependencies are OK in 1.13.x but not in 1.12.x.)
systemd.special(7) says
"""
All services for which the availability of the full user/group database is essential should be ordered after this target, but not pull it in.
"""
which I think means "use After, don't use Requires"?
Philip Withnall <bugzilla@tecnocode.co.uk>
5/1/2018
-----------------------------------------------------------------
Nitpick: s/synchronization points/synchronization point/ in the commit message.
Powered by Splinter

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.