Bug 34393:
reaching incoming message limit can cause locking violations -
Simon McVittie <smcv@collabora.com> -
2/17/2011
Back to Bug |
Your Reviews |
Help
Attachment 43819:
When attaching counters to messages, don't automatically notify callbacks -
Simon McVittie <smcv@collabora.com> -
2/25/2011
(
View
)
Close Quick Help
- From the Overview page, you can add a more generic overview comment that will appear at the beginning of your review.
- To comment on a specific lines in the patch, first select the filename from the file navigation links.
- Then double click the line you want to review and a comment box will appear below the line.
- When the review is complete and you publish it, the overview comment and all line specific comments with their context,
will be combined together into a single review comment on the bug report.
- For more detailed instructions, read the Splinter
help page.
From: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: Fri, 25 Feb 2011 17:21:44 +0000
Subject: [PATCH 06/10] When attaching counters to messages, don't automatically notify callbacks
In all the places where counters are added, we're under a lock. The caller
knows what effect adding the counter might have, and can replicate it
in a lock-safe way if necessary.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=34393
(Restored from draft; last edited )