Bug 50563: Add Telepathy observer - Seif Lotfy <seif@lotfy.com> - 5/31/2012 Back to Bug | Your Reviews | Help
Attachment 62594: Telepathy observer patch - Seif Lotfy <seif@lotfy.com> - 6/5/2012 (View )

Show Quick Help

From: Seif Lotfy <seif@lotfy.com>
Date: Wed, 30 May 2012 15:37:03 +0200
Subject: [PATCH] Add Telepathy Observer for logging calls, im and file
transfers Bumped versions for Zeitgeist and Valac
<Overall Comment>
Previous Reviews
Siegfried-Angel Gevatter Pujals <siggi.gevatter@gmail.com>
6/8/2012
-----------------------------------------------------------------
>> - Multi-user text conversations?
> Will not be logged since it is a pain and causes too much noise
How are you handling them, though? Shouldn't be a check somewhere so they are ignored?
>> - Why does the NFO_AUDIO object get named after the first contact?
> Do you have any better suggestions how we can call it? Leave it empty?
Anything that isn't misleading. "Call with X" for one person and "Call with N others" for >1 people would be a simple option (maybe event something like "Call with John, Mark and 3 others"). Or you can just hardcode it "Voice call" or leave it empty; I'm not sure there's much point in using this string in user visible interfaces anyway (they'll probably want to take the contact information and build something themselves).
>> - "event_template.set_interpretation (ZG_CREATE_EVENT); if (channel.requested
>> == false) event_template.set_manifestation (ZG_WORLD_ACTIVITY);" this is
>> duplicated in create_call_event and observe_call_channel (plus, if/else so
>> there's always a single assignment would be nicer).
This hasn't changed.
>> - I thought we'd decided to use namespaces in JSON payloads?
>I use them, the namespaces are defined on the top of the file
Right, sorry.
>> - Why is the list of call participants duplicated as subjects and in the JSON?
> Just for convenience. Is this a problem?
There isn't much point in doing so (and it increases the size of the DB; keep in mind that we can't even reuse the name strings, like happens with the subjects).
Powered by Splinter

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.