Attachment 70595:
Use ->priv where possible. -
Alexander Larsson <alexl@redhat.com> -
11/26/2012
(
View
)
Close Quick Help
- From the Overview page, you can add a more generic overview comment that will appear at the beginning of your review.
- To comment on a specific lines in the patch, first select the filename from the file navigation links.
- Then double click the line you want to review and a comment box will appear below the line.
- When the review is complete and you publish it, the overview comment and all line specific comments with their context,
will be combined together into a single review comment on the bug report.
- For more detailed instructions, read the Splinter
help page.
(Restored from draft; last edited )
Previous Reviews
Marc-Andre Lureau <marcandre.lureau@gmail.com>
11/26/2012
-----------------------------------------------------------------
(In reply to comment #0)
> We already have priv members in the structs, which are much much faster.
I don't think faster is really an argument here, given the rate at which we call those functions. However, I like the type-safety we had, especially on the public functions. Can you add SPICE_FOO(obj) checks in the public methods with this patch?