Bug 69585:
MC regression in 5.15.1: account-manager/connectivity.py fails -
Simon McVittie <smcv@collabora.com> -
9/19/2013
Back to Bug |
Your Reviews |
Help
Attachment 86158:
1/5] run-test.sh.in: now that we run under 'set -e', catch failures -
Simon McVittie <smcv@collabora.com> -
9/19/2013
(
View
)
Close Quick Help
- From the Overview page, you can add a more generic overview comment that will appear at the beginning of your review.
- To comment on a specific lines in the patch, first select the filename from the file navigation links.
- Then double click the line you want to review and a comment box will appear below the line.
- When the review is complete and you publish it, the overview comment and all line specific comments with their context,
will be combined together into a single review comment on the bug report.
- For more detailed instructions, read the Splinter
help page.
From: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: Thu, 19 Sep 2013 19:43:29 +0100
Subject: [PATCH 1/5] run-test.sh.in: now that we run under 'set -e', catch
failures
If we just let with-session-bus.sh exit nonzero, the script aborts.
We want to catch the nonzero exit status and do some more things
before failing.
---
tests/twisted/run-test.sh.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
(Restored from draft; last edited )
Previous Reviews
Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
9/20/2013
-----------------------------------------------------------------
++