Bug 50093:
[next] consider merging Contacts and Requests ifaces into Connection -
Xavier Claessens <xclaesse@gmail.com> -
5/18/2012
Back to Bug |
Your Reviews |
Help
Attachment 91670:
[salut next 3/5] tests: abolish Contacts interface -
Simon McVittie <smcv@collabora.com> -
1/8/2014
(
View
)
Close Quick Help
- From the Overview page, you can add a more generic overview comment that will appear at the beginning of your review.
- To comment on a specific lines in the patch, first select the filename from the file navigation links.
- Then double click the line you want to review and a comment box will appear below the line.
- When the review is complete and you publish it, the overview comment and all line specific comments with their context,
will be combined together into a single review comment on the bug report.
- For more detailed instructions, read the Splinter
help page.
From: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: Wed, 8 Jan 2014 13:04:12 +0000
Subject: [PATCH 3/5] tests: abolish Contacts interface
As with Gabble, I kept conn.Contacts working for now, but it's
now an alias for the default interface.
(Restored from draft; last edited )
Previous Reviews
Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
1/13/2014
-----------------------------------------------------------------
++