Bug 69430: Make NewChannels, etc., singular? - Simon McVittie <smcv@collabora.com> - 9/16/2013 Back to Bug | Your Reviews | Help
Attachment 92141: move RequestableChannelClasses to Connection - Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> - 1/15/2014 (View )

Show Quick Help

From: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: Wed, 15 Jan 2014 14:23:27 +0100
Subject: [PATCH] move RequestableChannelClasses to Connection
<Overall Comment>
Previous Reviews
Simon McVittie <smcv@collabora.com>
1/15/2014
-----------------------------------------------------------------
Looks good, except:
doc/templates/interface.html
380 and <a href="Channel_Dispatcher.html">ChannelDispatcher</a>.
381 If supported on this protocol, the property should appear in either the
382 Fixed_Properties or Allowed_Properties of
383 a <a href="Connection_Interface_Requests.html#im.telepathy.v1.Connection.RequestableChannelClasses">RequestableChannelClass</a>
should also be Connection.html#... now
(and maybe grep for other uses of that filename)
394 and <a href="Channel_Dispatcher.html">ChannelDispatcher</a>.
395 The property should also appear in either the Fixed_Properties
396 or Allowed_Properties of
397 a <a href="Connection_Interface_Requests.html#im.telepathy.v1.Connection.RequestableChannelClasses">RequestableChannelClass</a>
likewise
Powered by Splinter

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.