Bug 71384: improve account storage GInterface - Simon McVittie <smcv@collabora.com> - 11/8/2013 Back to Bug | Your Reviews | Help
Attachment 93549: Let account storage plugins load asynchronously - Simon McVittie <smcv@collabora.com> - 2/6/2014 (View )

Show Quick Help

From: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: Thu, 6 Feb 2014 14:56:38 +0000
Subject: [PATCH 2/2] Let account storage plugins load asynchronously
This means they don't have to be prepared to block during list().
(tests/twisted/mcp-account-diversion.c still loads its data at the last
possible moment, in list(), to confirm that the no-op default implementation
of list_async and list_finish works as intended.)
<Overall Comment>
Previous Reviews
Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
2/14/2014
-----------------------------------------------------------------
src/mcd-storage.c
2386 gpointer user_data)
2387{
2388 GList *store;
2389 GTask *task = g_task_new (self, NULL, callback, user_data);
2390 gsize remaining = 1;
I'd add a comment explaining why you start at '1' instead of 0, it's not that clear to me.
Powered by Splinter

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.