Bug 55109: GVariant-based factory instantiation - Simon McVittie <smcv@collabora.com> - 9/19/2012 Back to Bug | Your Reviews | Help
Attachment 94879: client-factory: take a vardict for new channel props - Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> - 2/28/2014 (View )

Show Quick Help

From: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: Thu, 27 Feb 2014 13:07:16 +0100
Subject: [PATCH 6/6] client-factory: take a vardict for new channel props
<Overall Comment>
Previous Reviews
Simon McVittie <smcv@collabora.com>
2/28/2014
-----------------------------------------------------------------
telepathy-glib/base-client.c
1542 _tp_connection_set_account (*connection, *account);
1543 
1544 *channel = tp_client_factory_ensure_channel (self->priv->factory,
1545 *connection, chan_path, tp_asv_to_vardict (chan_props), error);
Non-floating, leaked
telepathy-glib/channel-dispatch-operation.c
277 return;
278 
279 self->priv->channel = tp_client_factory_ensure_channel (
280 tp_proxy_get_factory (self), self->priv->connection, path,
281 tp_asv_to_vardict (properties), &error);
Non-floating, leaked
telepathy-glib/channel-request.c
222 }
223 
224 channel = tp_client_factory_ensure_channel (tp_proxy_get_factory (self),
225 connection, chan_path, tp_asv_to_vardict (chan_props), &error);
Non-floating, leaked
telepathy-glib/client-factory.c
775 }
776 
777 if (immutable_properties != NULL)
778 {
779 g_variant_ref_sink (immutable_properties);
Sink before calling the vfunc
tests/dbus/call-channel.c
154 g_assert_no_error ((GError *) error);
155 
156 test->chan = tp_client_factory_ensure_channel (test->factory,
157 connection, object_path, tp_asv_to_vardict (immutable_properties),
leaked
874 g_assert (test->chan == NULL);
875 
876 test->chan = tp_client_factory_ensure_channel (test->factory,
877 conn, object_path, tp_asv_to_vardict (properties), &error);
leaked
tests/dbus/dbus-tube.c
139 
140 factory = tp_proxy_get_factory (test->connection);
141 test->tube = (TpDBusTubeChannel *) tp_client_factory_ensure_channel (
142 factory, test->connection, chan_path, tp_asv_to_vardict (props),
leaked
tests/dbus/file-transfer-channel.c
216 
217 factory = tp_proxy_get_factory (test->connection);
218 test->channel = TP_FILE_TRANSFER_CHANNEL (tp_client_factory_ensure_channel (
219 factory, test->connection, chan_path, tp_asv_to_vardict (props),
leaked
tests/dbus/stream-tube.c
208 
209 factory = tp_proxy_get_factory (test->connection);
210 test->tube = TP_STREAM_TUBE_CHANNEL (tp_client_factory_ensure_channel (
211 factory, test->connection, chan_path, tp_asv_to_vardict (props),
leaked
tests/dbus/text-channel.c
83 
84 factory = tp_proxy_get_factory (test->connection);
85 test->channel = TP_TEXT_CHANNEL (tp_client_factory_ensure_channel (factory,
86 test->connection, chan_path, tp_asv_to_vardict (props), &test->error));
leaked
107 NULL);
108 
109 test->sms_channel = TP_TEXT_CHANNEL (tp_client_factory_ensure_channel (
110 factory, test->connection, chan_path, tp_asv_to_vardict (props),
leaked
tests/lib/util.c
678 
679 factory = tp_proxy_get_factory (conn);
680 return tp_client_factory_ensure_channel (factory, conn,
681 object_path, tp_asv_to_vardict (immutable_properties), error);
leaked
Powered by Splinter

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.