Bug 76828:
[next] TpClientFactory should be the top level singleton -
Xavier Claessens <xclaesse@gmail.com> -
3/31/2014
Back to Bug |
Your Reviews |
Help
Attachment 96679:
[4/4] TpClientFactory: consistently use _ensure_ when creating objects -
Simon McVittie <smcv@collabora.com> -
3/31/2014
(
View
)
Close Quick Help
- From the Overview page, you can add a more generic overview comment that will appear at the beginning of your review.
- To comment on a specific lines in the patch, first select the filename from the file navigation links.
- Then double click the line you want to review and a comment box will appear below the line.
- When the review is complete and you publish it, the overview comment and all line specific comments with their context,
will be combined together into a single review comment on the bug report.
- For more detailed instructions, read the Splinter
help page.
From: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: Mon, 31 Mar 2014 20:04:11 +0100
Subject: [PATCH] TpClientFactory: consistently use _ensure_ when creating
objects
Xavier was going for "singletons use _dup_, objects that are per-path
use _ensure_" but we agreed that using _ensure_ for both was less
confusing.
(Restored from draft; last edited )