Created attachment 18614 [details] [review] Patch for xevie The XEvIE extension doesn't clear the rep.length field for any reply but the version check. Hence, if there is junk data in it and that is sent to the client, it hangs. This was observed on debian testing, where the 32-bit server did leave junk data in the field (and hence XEvIE didn't work), whereas on 64-bit the value happened to be 0, so XEvIE worked fine. The attached patch fixes this.
On Mon, Sep 1, 2008 at 09:38:06 -0700, bugzilla-daemon@freedesktop.org wrote: > Created an attachment (id=18614) > --> (http://bugs.freedesktop.org/attachment.cgi?id=18614) > Patch for xevie > Applied, thanks! commit d3ae193f4ac87530f2745f8cb5e7b70dd516881e Author: Thorvald Natvig <slicer@users.sourceforge.net> Date: Mon Sep 1 19:36:56 2008 +0200 Xevie: always initialize rep.length (bug#17394) The XEvIE extension doesn't clear the rep.length field for any reply but the version check. Hence, if there is junk data in it and that is sent to the client, it hangs. X.Org bug#17394 (http://bugs.freedesktop.org/show_bug.cgi?id=17394)
I have only tested XEvIE on xserver 1.4, but it also hangs there. Is there any chance for this patch to be cherry-picked to the 1.4 and 1.5 branches? Thanks
(In reply to comment #2) > I have only tested XEvIE on xserver 1.4, but it also hangs there. Is there any > chance for this patch to be cherry-picked to the 1.4 and 1.5 branches? You can nominate it on http://www.x.org/wiki/Server15Branch
> --- Comment #2 from Rémi Cardona <remi@gentoo.org> 2008-09-03 00:20:13 PST --- > I have only tested XEvIE on xserver 1.4, but it also hangs there. Is there any > chance for this patch to be cherry-picked to the 1.4 and 1.5 branches? > Was cherry-picked for 1.5 final.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.