The AGotoCallButton is never shown and basically unused code, and accordingly RID_IMGBTN_GOTOCALL. So it should be removed. See http://wiki.documentfoundation.org/Development/Easy_Hacks#Remove_obsolete_product_pieces
Created attachment 45602 [details] [review] Remove unused aGotoCallButton and RID_IMGBTN_GOTOCALL
ok, taking it
Thanks for the patch, it's pushed ( I also removed the id completely from the source ( svx/inc/svx/svxids.hrc ) commits are here http://cgit.freedesktop.org/libreoffice/components/commit/?h=libreoffice-3-4&id=7eba32f0eacd71fbf2561c9f58f52b89cdd0e86f http://cgit.freedesktop.org/libreoffice/libs-core/commit/?h=libreoffice-3-4&id=31dd8b55accd586d454280814b1ad856802454ef
mark as fixed
=== Remove specific dead code === '''Background:''' We have lots of dead code around, one example is: basicide/source/basicide/baside2b.cxx - where we have code related to RID_IMGBTN_GOTOCALL that creates an aGotoCallButton that has no icon and is always hidden. We should remove both the code, the .src and .hrc defines. '''Skills:''' simple C++ '''Finished the part of removing aGotoCallButton''': Christian Dywan, christian.dywan@lanedo.com, 2011-04-21 [https://bugs.freedesktop.org/show_bug.cgi?id=36230 fdo#36230]
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.