Bug 39674 - find / fix all German spellings in internal APIs
Summary: find / fix all German spellings in internal APIs
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Libreoffice (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Not Assigned
QA Contact:
URL:
Whiteboard: EasyHack DifficultyBeginner SkillScri...
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-29 10:55 UTC by Björn Michaelsen
Modified: 2014-08-30 08:57 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Björn Michaelsen 2011-07-29 10:55:37 UTC
find / fix all German spellings in internal APIs

Background: There are a good number of misspelled methods. For instance 'childs' should be children and 'menues' menus, layoutetText should be layedOutText etc.

Skills: grep, German, code reading
Comment 1 Chris Cunningham 2011-08-03 06:38:44 UTC
That's "LaidOutText", surely?
Comment 2 Florian Allmann-Rahn 2011-08-14 03:35:34 UTC
This task does not refer to the spelling/grammar mistakes in the German UI, does it?
Comment 3 Björn Michaelsen 2011-11-18 09:03:57 UTC
@Florian: no, that would be something completely different: https://translations.documentfoundation.org/
Comment 4 Florian Reisinger 2012-05-18 09:09:58 UTC
Deteted "Easyhack" from summary
Comment 5 Not Assigned 2013-02-22 11:57:03 UTC
Thomas Arnhold committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=5c89214a80f0284eafaf4eba23243dfe3c9f7193

fdo#39674: Rename menues to menu



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 6 Thomas Arnhold 2013-03-10 10:11:04 UTC
Good point to start: sc/source/core/tool/interpr2.cxx

void ScInterpreter::ScLaufz()
double ScInterpreter::ScGetZinsZ()
void ScInterpreter::ScKapz()

And many more German words, like "Rest, Faktor, Zins, Effektiv, Nominal"...

Some more:

DeleteAktPara() [sw/source/core/edit/autofmt.cxx]
NeueTabelle() [sc/source/filter/excel/impop.cxx]

And common German words which don't occur in English:

Objekt, Klasse, Fenster, Graphik, Grafik, Menue, Charakter, Komma, PLZ, ObjectMenue

akt, isch, ae, oe, ue, ä, ü, ö
Comment 7 Commit Notification 2013-10-04 15:50:54 UTC
Thomas Arnhold committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=be62c01287c095c22a83ecfe6f9f45874f6e56f8

fdo#39674 fix some spelling



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 8 Thomas Arnhold 2013-10-04 16:24:50 UTC
sc/source/core/tool/interpr2.cxx is still full of them.
Comment 9 Björn Michaelsen 2013-10-04 18:46:52 UTC
adding LibreOffice developer list as CC to unresolved EasyHacks for better visibility.

see e.g. http://nabble.documentfoundation.org/minutes-of-ESC-call-td4076214.html for details
Comment 10 Thomas Arnhold 2013-12-15 09:23:57 UTC
One more: sw/source/core/text/wrong.cxx:

nOben, nUnten, nMitte in SwWrongList::GetWrongPos()
Comment 11 Philipp Riemer 2014-01-06 16:03:24 UTC
(In reply to comment #10)
> One more: sw/source/core/text/wrong.cxx:
> 
> nOben, nUnten, nMitte in SwWrongList::GetWrongPos()

Done with commit:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=62ab589282ad4fb96e1b8d1f9cc13090276f49ca
Comment 12 jonathan lucas 2014-07-30 16:44:03 UTC
Hi, I would like to contribute (native German), as I just read on Micheal Meeks' blog that help is still needed. How/where can I start? Feel free to contact me!
Comment 13 Noel Grandin 2014-07-31 08:03:27 UTC
Jonathon, you will need to check out the source code, and then run the script

./bin/find-german-comments

Then pick a place to start and focus on cleaning up one location.

Come hang out on the IRC channel if you need more help.
Comment 14 Thomas Arnhold 2014-08-03 12:23:49 UTC
Noel: This bug is about API names, not comment translation!

Jonathan: See Comment 8, in sc/source/core/tool/interpr2.cxx. There are still many German variable names like "fDauer" and so on...

Comment 6 should give you a hint what to search for (git grep -i "text").
Comment 15 jeyli 2014-08-29 08:20:10 UTC
Committed a patch related to this issue. Translated German to English in sc/source/core/tool/interpr2.cxx
https://gerrit.libreoffice.org/#/c/11184/
Comment 16 Commit Notification 2014-08-30 08:48:12 UTC
Jennifer Liebel committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=5605a36a31081875087ff5cb28b84790845ba695

fdo#39674: Improved translation



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 17 Commit Notification 2014-08-30 08:57:27 UTC
Jennifer Liebel committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=e886f9ad66cf0e1961deebb30a97e0b35bb5a816

fdo#39674: translated German to English



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.