Thanks a lot Stephan.

I'll take care of these tests.

Disabled failing tests as <http://cgit.freedesktop.org/libreoffice/core/commit/?id=23b91df22b63558aa7dfd42270780db909b1e382>.  Please revert when fixed.

sc.ScCellRangeObj::com::sun::star::sheet::XCellRangesQuery
sc.ScCellCursorObj::com::sun::star::sheet::XCellRangesQuery

have the same implementation because both inherit it from ScCellRangeBase and therefore only need one test

the new test is written in c++ in sc/qa/extras/xcellrangesquery.cxx

I think the failure was due to different handling of string cells in LibO than in OOo and we may have a error in queryFormulaCells

remaining failing test cases:

sc.ScAccessiblePreviewCell::com::sun::star::accessibility::XAccessibleComponent
sc.ScAutoFormatFieldObj::com::sun::star::sheet::TableAutoFormatField
sc.ScCellCursorObj::com::sun::star::table::CellProperties
sc.ScCellObj::com::sun::star::table::CellProperties
sc.ScCellObj::com::sun::star::style::CharacterProperties
sc.ScCellObj::com::sun::star::beans::XPropertySet
sc.ScCellRangeObj::com::sun::star::table::CellProperties
sc.ScCellRangeObj::com::sun::star::util::XReplaceable
sc.ScCellRangesObj::com::sun::star::table::CellProperties
sc.ScCellRangesObj::com::sun::star::beans::XPropertySet
sc.ScDataPilotFieldObj::com::sun::star::sheet::DataPilotField

sc.ScAutoFormatFieldObj::com::sun::star::sheet::TableAutoFormatField seems to be broken in several ways.

This test could have never worked and is broken too. The failing part VertJustify only supports values 0 to 4 and the test tries to set it to 5. But then we have a change from Kohei which seems has broken the uno implementation for two properties:

http://opengrok.libreoffice.org/diff/core/sc/source/ui/unoobj/afmtuno.cxx?r2=%2Fcore%2Fsc%2Fsource%2Fui%2Funoobj%2Fafmtuno.cxx%407da57d17b6179e71c8b6d7549ad89eaf3a4a28c6&r1=%2Fcore%2Fsc%2Fsource%2Fui%2Funoobj%2Fafmtuno.cxx%404573ccfffda4c2bea55d1da2ac1357bcde91e67a

C++ based test is in sc/qa/extras/tableautoformatfield.cxx, tests are disabled for now

same problem for:

sc.ScCellCursorObj::com::sun::star::table::CellProperties
sc.ScCellObj::com::sun::star::table::CellProperties
sc.ScCellRangeObj::com::sun::star::table::CellProperties
sc.ScCellRangesObj::com::sun::star::table::CellProperties

see http://opengrok.libreoffice.org/diff/core/sc/source/ui/unoobj/cellsuno.cxx?r2=%2Fcore%2Fsc%2Fsource%2Fui%2Funoobj%2Fcellsuno.cxx%407da57d17b6179e71c8b6d7549ad89eaf3a4a28c6&r1=%2Fcore%2Fsc%2Fsource%2Fui%2Funoobj%2Fcellsuno.cxx%403024512c90d8660d35d4824471c436d68aa62241

all these tests will be merged into one single test because they share the same implementation

I think we should have one test suite per implementation class, that would result e.g. in a test suite for ScCellRangesBase which implements this part

remaining failing tests:

sc.ScAccessiblePreviewCell::com::sun::star::accessibility::XAccessibleComponent
sc.ScCellObj::com::sun::star::style::CharacterProperties
sc.ScCellRangeObj::com::sun::star::util::XReplaceable
sc.ScCellRangesObj::com::sun::star::beans::XPropertySet
sc.ScDataPilotFieldObj::com::sun::star::sheet::DataPilotField

implementation for:
sc.ScCellCursorObj::com::sun::star::table::CellProperties
sc.ScCellObj::com::sun::star::table::CellProperties
sc.ScCellRangeObj::com::sun::star::table::CellProperties
sc.ScCellRangesObj::com::sun::star::table::CellProperties

is at sc/qa/extras/cellproperties.cxx

makefile for file and xcellrangesquery.cxx is sc/Cppunit_sc_cellrangesbase.mk

sc.ScCellRangesObj::com::sun::star::beans::XPropertySet

should be the same problem, there will be no own implementation for this, 
the java test just tests all properties that are in CellProperties twice, once in the CellProperties test and once in the XPropertySet test, I just don't understand why we the XPropertySet does not fail for sc.ScCellCursorObj

sc.ScCellCursorObj::com::sun::star::table::CellProperties
sc.ScCellObj::com::sun::star::table::CellProperties
sc.ScCellObj::com::sun::star::beans::XPropertySet
sc.ScCellRangeObj::com::sun::star::table::CellProperties
sc.ScCellRangesObj::com::sun::star::table::CellProperties
sc.ScCellRangesObj::com::sun::star::beans::XPropertySet
sc.ScAutoFormatFieldObj::com::sun::star::sheet::TableAutoFormatField

are now fixed in master and will be therefore fixed in 3-5

They needed an api incompatible change in table::CellProperties and sheet::TableAutoFormatField

sc.ScDataPilotFieldObj::com::sun::star::sheet::DataPilotField does not fail as c++ based version

might just be that the java version has a design error, I'll push the c++ based version to sc/qa/extras/datapilotfieldobj.cxx

remaining failing tests:

sc.ScAccessiblePreviewCell::com::sun::star::accessibility::XAccessibleComponent
sc.ScCellObj::com::sun::star::style::CharacterProperties
sc.ScCellRangeObj::com::sun::star::util::XReplaceable

(In reply to comment #9)
> sc.ScDataPilotFieldObj::com::sun::star::sheet::DataPilotField does not fail as
> c++ based version
> 
> might just be that the java version has a design error, I'll push the c++ based
> version to sc/qa/extras/datapilotfieldobj.cxx
> 
> remaining failing tests:
> 
> sc.ScAccessiblePreviewCell::com::sun::star::accessibility::XAccessibleComponent
> sc.ScCellObj::com::sun::star::style::CharacterProperties
> sc.ScCellRangeObj::com::sun::star::util::XReplaceable

Hi all,

This test failed for me this morning on my master build pulled and made last night.


Alex

just for the record, test failed because there were some lock files from an earlier run

and sc_datapilotfield contains more tests, it also tests for ScDataPilotFieldObj::XDatapilotFieldGrouping

It seems that nearly all XReplaceable methods are broken. Not only in calc, we should look into that.

Can reproduce the problem with a c++ based test with:

sc.ScCellRangeObj::com::sun::star::util::XReplaceable

but not with

sc.ScTableSheetObj::com::sun::star::util::XReplaceable

My mistake. Can't reproduce it with a c++ based test.

I suspect that the java test is not totally correct.

Pushed a c++ based test for sc.ScCellRangeObj::com::sun::star::util::XReplaceable

Remaining issues:

sc.ScAccessiblePreviewCell::com::sun::star::accessibility::XAccessibleComponent
sc.ScCellObj::com::sun::star::style::CharacterProperties

This bug hasn't seen any action. Freeing this bug and switching ASSIGNED to NEW

Markus if you are still working on this, please re-assign yourself.