So... the configmgr code has an existing unit test, but this test is not used for anything, which is a shame - since it does some nice multi-threaded access test and would provide a base to extend these tests. One reason for this disablement is that the UNO-ness it requires has been traditionally required takes -so- much lifting to bootstrap and startup. Nowadays much of this pain has already been pre-suffered, so we should be able to take a unit test makefile eg. sc/CppUnitTest_sc_ucalc.mk and adapt it to configmgr/ - hooking the test into Module_configmgr.mk - cf. the sc/ module. Of course we need to cut out a big scad of components needed to run the test, and remove almost all of the linked_libs [ check configmgr/prj/build.lst to see what libraries we know are compiled beforehand ]. Possibly if there are dependency issues we want to make this a 'slowcheck' target, that we know will be built rather later in the process. Then we want to enable the configmgr/qa/unit/unit.cxx test - remove the version map in there, and try to make it complete :-) Help / incremental patches towards that much appreciated. Thanks.
Deleted "Easyhack" from summary.
Created attachment 81213 [details] makefile for unit test Ok I've been working on this bug. I've added these changes to the unit and current module.mk http://sprunge.us/MjKj But I seem to miss an include, but I don't know how to fix this issue, I'm stuck ;). /home/jelle/media/core/configmgr/qa/unit/test.cxx:24:45: fatal error: com/sun/star/beans/NamedValue.hpp: No such file or directory #include "com/sun/star/beans/NamedValue.hpp"
Jelle van der Waa committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=e8c26959deac60eb2b7bec7a36fccacd95914304 fdo#46723 enable configmgr unit tests The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Hey - thanks so much for fixing this - I've pushed another makefile cleanup; with this I think we should git rm the data.xcd - we can now operate inside unit tests on the real configuration for LibreOffice ... So - we should port the individual tests to use real config paths that exist in the configuration instead of trying to use the data.xcd paths that don't exist :-) We should prolly also add one or two of Noel's new-style configuration accessors in there, just to exercise them a bit - in fact, Noel would be an excellent mentor for the rest of this issue. Thanks !
(In reply to comment #3) > Jelle van der Waa committed a patch related to this issue. > It has been pushed to "master": > > http://cgit.freedesktop.org/libreoffice/core/commit/ > ?id=e8c26959deac60eb2b7bec7a36fccacd95914304 > > fdo#46723 enable configmgr unit tests but CppunitTest_configmgr_unit is still commented out in configmgr/Module_configmgr.mk?
Sure - it's commented out because the test fails :-) the tests need porting to use keys inside the default LibreOffice config schema, and then life will be better I think.
adding LibreOffice developer list as CC to unresolved EasyHacks for better visibility. see e.g. http://nabble.documentfoundation.org/minutes-of-ESC-call-td4076214.html for details
Removing comma from whiteboard (please use a space to delimit values in this field) https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Whiteboard#Getting_Started
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.