Bug 48659 - about dialog misses Build ID in Dutch langpack
Summary: about dialog misses Build ID in Dutch langpack
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Libreoffice (show other bugs)
Version: Master old -3.6
Hardware: Other Linux (All)
: medium normal
Assignee: Caolán McNamara
QA Contact:
URL:
Whiteboard: target:3.6.0
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-13 11:06 UTC by Cor Nouws
Modified: 2012-05-01 05:31 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
screen shot about dialog 120410 (119.76 KB, image/png)
2012-04-13 11:06 UTC, Cor Nouws
Details
Fix (2.78 KB, patch)
2012-04-14 08:44 UTC, Andrew
Details | Splinter Review
scren shot about dialog (113.45 KB, image/png)
2012-04-18 03:57 UTC, Cor Nouws
Details

Description Cor Nouws 2012-04-13 11:06:34 UTC
Created attachment 59924 [details]
screen shot about dialog 120410

Hi *
Thanks for the beautiful new about dialog!
Two possibilities for improvement:
 - the dialog misses Build ID 
 - Esc does not close it

I'll attach a screenshot.

My version is 
  http://dev-builds.libreoffice.org/daily/Linux-x86_10-Release_Configuration/master/current/master~2012-04-10_16.04.34_LibO-Dev_3.6.0alpha0_Linux_x86_install-deb_en-US.tar.gz
from
  http://dev-builds.libreoffice.org/daily/Linux-x86_10-Release_Configuration/master/current/

(Sorry for 2 issues in one bug - bad for my rating too ;-) )
Comment 1 Cor Nouws 2012-04-13 11:08:47 UTC
obvisouly related to this commit
  8a3aae9b694deb2b41157509e84815a5b7fb7655
Comment 2 Andrew 2012-04-14 08:10:09 UTC
Hmm.. that is odd, the build ID is in the description (LODev daily##### should be 'LibreOffice')

I will have a quick look
Comment 3 Andrew 2012-04-14 08:29:56 UTC
Ooops sorry, no that is correct, the Build ID is just left off.
I will have a look...
Comment 4 Andrew 2012-04-14 08:44:33 UTC
Created attachment 59977 [details] [review]
Fix

Okay so I believe this patch should fix the issue.

'(Build ID: #####)' should not appear if the build id is empty, however this check obviously didn't work so I have made it check is the [build id trimmed of all spaces] is empty, which should now work - Cor could you test this?

Regarding the ESC key, I don't immediately know how to do this, and it isn't strictly a bug (an enhancement) so could you file it as a separate report Cor?
Comment 5 Cor Nouws 2012-04-15 02:21:02 UTC
Hi Andrew,
(In reply to comment #2)
> Hmm.. that is odd, the build ID is in the description (LODev daily##### should
> be 'LibreOffice')

Ah yes, I should have wanred you for that.
I allways change the <oooname> in the /share/registry/main.xcd
That helpt me to see quickly in which of the many versions I work ;-)
Comment 6 Cor Nouws 2012-04-15 02:29:27 UTC
(In reply to comment #4)
> - Cor could you test this?

Not sure. When the patch is pushed to master, we'll see there and also maybe cases different then my local repo will be tested.

> Regarding the ESC key, I don't immediately know how to do this, and it isn't
> strictly a bug (an enhancement) so could you file it as a separate report Cor?

IMO it's a real bug when ESC does not close a dialogue. But OK, here is the separate issue :-) :  Bug 48723 - new about dialog does not close with ESC (edit) 

thanks so far!
Comment 7 Not Assigned 2012-04-16 08:37:25 UTC
Andrew Higginson committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=f73d26889692599aadaba28db406f430b9af7d8c

Resolves: fdo#48659 about dialog misses BuildID
Comment 9 Cor Nouws 2012-04-18 03:57:23 UTC
so reopen
Comment 10 Caolán McNamara 2012-04-25 07:28:21 UTC
*scratches head*, I downloaded http://dev-builds.libreoffice.org/daily/Linux-x86_10-Release_Configuration/master/current/master~2012-04-17_13.43.52_LibO-Dev_3.6.0alpha0_Linux_x86_install-rpm_en-US.tar.gz and I have a build-id listed.

Can I get the /opt/lodev3.6/program/versionrc from an affected version please (*)

(*) and converting buildid=46e18bc-af20ea3-05f89ef-ae7aae4-186d9e to buildid= in /opt/lodev3.6/program/versionrc "does the right thing" as far as I can see.
Comment 11 Caolán McNamara 2012-04-25 07:32:00 UTC
oh wait, if I install the *Dutch* langpack and start in a dutch locale I see it
Comment 12 Caolán McNamara 2012-04-25 08:07:51 UTC
So, lets force " $BUILDID" at the end of the string if a translations is missing the $BUILDID placeholder, that should take care of it. And the problem goes away when translations are updated anyway.
Comment 13 Not Assigned 2012-04-25 08:12:42 UTC
Caolan McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=fd257f9e1936b0bc9bc9116bd73eaa04a7dbd060

Resolves: fdo#48659 force BUILDID placeholder in if missing from translation
Comment 14 Cor Nouws 2012-05-01 05:31:36 UTC
thanks!
verified in version 3.6.0alpha0+ Build ID: 87897ea


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.