Bug 54541 - [Bisected i915]Piglit texturing_gen-texsubimage fails
Summary: [Bisected i915]Piglit texturing_gen-texsubimage fails
Status: VERIFIED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/i915 (show other bugs)
Version: git
Hardware: All Linux (All)
: high major
Assignee: Anuj Phogat
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-05 08:52 UTC by lu hua
Modified: 2012-12-19 06:52 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments

Description lu hua 2012-09-05 08:52:10 UTC
System Environment:
--------------------------
Arch:             i386
Platform:         Pineview
Libdrm:    (master)libdrm-2.4.39-2-g92fd0ce4f659d7b0680543e9e5b96a3c7737a5f3
Mesa:    (master)9a31e090efb15ec34e7a1a5e707d600a11d74925
Xserver:(master)xorg-server-1.12.99.905-12-g148583d62b84832369e9df39b3e527b99ca96761
Xf86_video_intel:(master)2.20.6-8-g18d26076c778c20eb589b638fc47fa847793f149
Libva:    (staging)9f5cfb90b8c89b1c91692c2f58c0a02eaf7ee682
Libva_intel_driver:(staging)f842b5021acbf093572a1bd0f86d32ff3e08621e
Kernel:    (drm-intel-nightly) af5f39db001bf71cb53a5026073f7dddbf2bd9a4

Bug detailed description:
-------------------------
It fails on Pineview with mesa master branch.It doesn't happen on mesa 9.0
branch.

Bisect shows:0fc11a24c85413a335b87bc34659d2381fd6670c is the first bad commit.
commit 0fc11a24c85413a335b87bc34659d2381fd6670c
Author:     Anuj Phogat <anuj.phogat@gmail.com>
AuthorDate: Wed Aug 29 11:13:55 2012 -0700
Commit:     Anuj Phogat <anuj.phogat@gmail.com>
CommitDate: Wed Aug 29 11:43:52 2012 -0700

    meta: Add GLSL variant of _mesa_meta_GenerateMipmap() function

    This reduces the overhead of using the fixed function internally
    in the driver.

    V2: Use setup_glsl_generate_mipmap() and setup_ff_generate_mipmap()
        functions to avoid code duplication.
        Use glsl version when ARB_{vertex, fragmet}_shader are present.
        Remove redundant code.

    V3: Remove redundant border related code leaving the assertion.

    Signed-off-by: Anuj Phogat <anuj.phogat@gmail.com>
    Reviewed-by: Ian Romanick <idr@freedesktop.org>
    Reviewed-by: Brian Paul <brianp@vmware.com>

output:
Probe at (128,384)
  Expected: 1.000000 0.000000 0.000000
  Observed: 0.000000 0.000000 1.000000
PIGLIT: {'result': 'fail' }

Reproduce steps:
----------------------------
1. xinit
2. ./bin/gen-texsubimage -auto
Comment 1 lu hua 2012-09-07 02:56:49 UTC
Following piglit cases also fail and have same bisect commit:
fbo_fbo-generatemipmap-formats 
spec_ARB_ES2_compatibility_fbo-generatemipmap-formats
Comment 2 Anuj Phogat 2012-09-14 18:35:03 UTC
My recent commits (299acac and 15bf310) on mesa master might fix this issue. I don't have a pineview system to verify.
Comment 3 lu hua 2012-09-19 09:13:40 UTC
It still happens on mesa master branch commit 7d624799b9db3a4a6e52682.
Comment 4 lu hua 2012-12-19 06:52:10 UTC
Fixed on commit dc613f11ddf1f3a6e10c2d99830fb1a84fdb55b2.
Comment 5 lu hua 2012-12-19 06:52:27 UTC
Verified.Fixed.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.