Created attachment 72362 [details] Cursor is in Left Side whereas the Cursor as to be to Right When an Table is Inserted in Impress The table alignment shows in Center For LTR Table And When the table is Converted to RTL Table The Cursor Position is Still in Left, Actually the cursor has to be in Right Side in each cell
confirmed with Libreoffice 3.6 in ubuntu 12.04
Created attachment 75161 [details] Alignment Problem Problem still exist with alignment of the table. In RTL Table the text alignment has to be Right but it is not. And their is another problem when we perform undo operation the alignment moves to center whereas it has to be to Left
Created attachment 75168 [details] Behavior after patch I have proposed an patch for this https://gerrit.libreoffice.org/#/c/2290/ Check the attachment for the current behavior. But the Other problem which i have stated in previous comment still exist. When undo operation is performed the alignment shifts to Center.
I would suggest inputs from UX team, please?
I haven't reviewed the patch (yet), but I think we need to better define the bug we want to fix. Problem #1: When inserting a table into impress, and checking it's alignment the result is aligned to the left. After selecting another object and checking the table again it's alignment change to the center. Problem #2: Changing table directionality doesn't change cell's alignment (which stays to the left), although directionality is now RTL. From the screenshot I couldn't understand to which problem are you referring. Let me know which of the problems the patch fixes, and I'll test it.
(In reply to comment #5) > From the screenshot I couldn't understand to which problem are you > referring. Let me know which of the problems the patch fixes, and I'll test > it. The Actual Problem when i reported is problem#2 that you have mentioned in previous comment. When we change the table from LTR to RTL, The alignment has to be to Right, But present behavior is all cell alignment still Remains in Left. My Patch works Towards this problem. As per my analysis, when the SvxAdjust is set to Center it will never change to Right so instead of checking it for Left while setting Right, If we check if it is right or not. and then set the value. When i was working on this i see their is another problem in undo, which does not shift back properly, we can report this as separate bug. Because the alignment was center when we change LTR table to RTL and do undo it changes to Center.
Gokul committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=909d745baf9a5d071892d8c04874ff279a9a477e Fix for fdo#58919 now the cursor/alignment is Right for RTL Table The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Lior Kaplan committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=c60c9d7de6f3cb89fc7e582d0ca173985ccc1a8a Revert "Fix for fdo#58919 now the cursor/alignment is Right for RTL Table" The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
The commit above was reverted with coordination with Gokul, as it creates a regression - changing directionality overrides center/justify alignment. We agreed on this preferred behavior: "In any case, the directionality should behave as in writer, which does affect the alignment, but only if it's left/right (not center/justify)."
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.